<table><tr><td style="">jfita created this revision.<br />jfita added reviewers: staniek, piggz.<br />Herald added a project: KDb.<br />Herald added a subscriber: Kexi-Devel-list.<br />jfita requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29184">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>kdbfeaturetest gave the following error when trying to test buffered<br />
cursors:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">> .//kdbfeaturestest --buffered-cursors --test cursors sqlite /tmp/cursor.test
DRIVERS: ("org.kde.kdb.postgresql", "org.kde.kdb.sqlite")
org.kde.kdb.core: loading "org.kde.kdb.--buffered-cursors"
KDbResult: CODE=10 MESSAGE="Could not find database driver \"org.kde.kdb.--buffered-cursors\"." SERVER_ERROR_CODE=0
main: "cursors" test: ERROR</pre></div>
<p>kdbfeaturetest’s main tries to remove all arguments from args[] before<br />
using the first remaining string as the driver’s name, but the code that<br />
removes --buffered-cursors and --query-parameters was below the one for<br />
the driver. Therefore, it assumed that either of the two, since they<br />
where still in args, was the driver’s name.</p>
<p>I just moved the two calls to take those parameters above the driver.</p>
<p>FIXED-IN:3.2.1</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R15 KDb</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29184">https://phabricator.kde.org/D29184</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>tests/features/main.cpp</div></div></div><br /><div><strong>To: </strong>jfita, staniek, piggz<br /><strong>Cc: </strong>Kexi-Devel-list, barman, wicik, staniek<br /></div>