<table><tr><td style="">piggz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14486">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14486#301208" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14486#301208</a>, <a href="https://phabricator.kde.org/p/staniek/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@staniek</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14486#301205" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14486#301205</a>, <a href="https://phabricator.kde.org/p/piggz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@piggz</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>A few questions, in the interest of keeping our downastream happy, and potentially reducing our burden</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">do we carry patches ontop of mdb?</li>
<li class="remarkup-list-item">how much work would be neded in adding a switch to use the system lib? --I know this would initially be a little work, but could allow a phased approach to using the system supplied lib over time, as packagers choose. If after 1-2 years, all packagers are onboard, we could then make it the default and remove our version of mdb, and the need to maintain it.</li>
</ol></div>
</blockquote>
<p>Thanks for stepping up Adam. I am not sure if:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">mdbtools carries version information .</li>
<li class="remarkup-list-item">It even does not maintain cmake module.
<br /><br />
This work is needed in mdbtools itself. And we have no evidence there's any other consumer apart of KEXI that uses mdbtools via cmake.
<br /><br />
If above bits are supplied and maintained, we could allow exact version of "system" mdbtools. Exact because it's the only one I test.
<br /><br />
IMHO it's more effort and risk than benefit, from history I remember that distros can:</li>
<li class="remarkup-list-item">skip mdbtools if we set it optional -> KEXI lacks major feature</li>
<li class="remarkup-list-item">skip KEXI if we set mdbtools required -> KEXI disappears from the distro at least for some time, for packagers it's "just" one release less
<br /><br />
Because I am all for seeing any contributions please go ahead to discuss[*] and contribute 1. and 2., then we can have opt-in "system" mdbtools support. We would keep mdbtools mandatory (as long as glib and iconv is present).
<br /><br />
Discuss[*]: your challenge would be that mdbtools is consisted of things orthogonal to MDB support KEXI needs: importer tool, exporter tool, SQL support. Whether that project will let you contribute just cmake files for the MDB C API for the read support is not clear. So there may be more work than KEXI needs.</li>
</ol></div>
</blockquote>
<p>out of interest, i was looking to see what mdbtools provides, and they have pkgconfig support we could likely use, but then I came across a maintained fork called cyber-mdbtools, which may be more open to contributions and packaging, and they already have fixes ontop of mdbtools 0.7.1.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R71 Kexi</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14486">https://phabricator.kde.org/D14486</a></div></div><br /><div><strong>To: </strong>staniek, piggz<br /><strong>Cc: </strong>anthonyfieroni, pino, Kexi-Devel-list, clybekk, barman, staniek<br /></div>