<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 22 October 2016 at 10:08, Treeve Jelbert <span dir="ltr"><<a href="mailto:treeve@scarlet.be" target="_blank">treeve@scarlet.be</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I wnat to use kreport in my project, so I copied the kreport/exam[ple files and tried to build it.<br>
Using the latest git checkout of kreport (ff46de3df63c124f2ab19573befa2<wbr>1b94824dd7f) my project build fails against the installed kreport, as KReportUtils_p.h is not installed.<br>
<br>
Would it be reasonable to expect this file to exist, or should I just ignore <div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default"></div>setupGlobalIconTheme?<br>
<br></blockquote><div><br><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default">Treeve, one thing more. You can remove the </div> <div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default"></div><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default">setupGlobalIconTheme() call and the #include.<br><br></div><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default">Below I decided to add more explanation what happens if you do. This long text could later go to the source code or documentation. Sorry if it's too complex for the task you have. The info applies also for the KProperty framework and Kexi.<br><br>- - -<br><br></div><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default">The call is responsible for setting up an icon theme for the app. If you run the app in environment that sets icon theme already so Qt's QIcon (QIcon::fromTheme to be strict) can find any generic icons (such as these for Copy or Paste actions), the app will display the icons without a need for calling setupGlobalIconTheme(). If the theme is missing (e.g. on stripped-down non-desktop Linux or Windows or Mac), setupGlobalIconTheme() may be needed to get any generic icons.<br></div></div></div><br><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default">setupGlobalIconTheme(), as implemented for KReport</div><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default"> 3.0.0, sets the icon theme to KDE's "Breeze" theme. This is because KReport-specific icons (for example "Barcode") are only available in the "Breeze" flavour currently so this default results in a perfect match of look for icons in apps that use KReport. Otherwise, for example Breeze and Tango/Oxygen icons would be an unpleasant mix. So in 3.0.0 we have something that looks consistent within the whole app, on any platform.<br><br></div><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default">If setupGlobalIconTheme() is commented out and current system's icon theme is used, we have better consistency with the system at the cost of visual inconsistencies within the app.<br></div><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default">To improve that, we clearly welcome contributions of KReport's icons for other themes than Breeze.<br></div><br>-- <br><div class="m_-1100383190086432393gmail_signature">regards, Jaroslaw Staniek<br><br>KDE:<br>: A world-wide network of software engineers, artists, writers, translators<br>: and facilitators committed to Free Software development - <a href="http://kde.org" target="_blank">http://kde.org</a><br>Calligra Suite:<br>: A graphic art and office suite - <a href="http://calligra.org" target="_blank">http://calligra.org</a><br>Kexi:<br>: A visual database apps builder - <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a><br>Qt Certified Specialist:<br>: <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/<wbr>jstaniek</a></div>
</div></div>