<table><tr><td style="">staniek created this revision.<br />staniek added a reviewer: piggz.<br />staniek added a subscriber: Kexi-Devel-list.<br />Restricted Application added a project: KReport.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2860" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">use kreport_THEME.rcc for library-global icons</li>
<li class="remarkup-list-item">use URL_THEME.rcc for plugin icons with prefix :/icons/URL so there is little risk of conflicts</li>
<li class="remarkup-list-item">use consistent kreport-foo-bar icon naming</li>
<li class="remarkup-list-item">make it easy to add new icons and plugins via cmake</li>
<li class="remarkup-list-item">make plugin files more unique (org.kde.kreport. prefix), helps in co-installation</li>
<li class="remarkup-list-item">make KReportExample work with the changes</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKREPORT KReport</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2860" rel="noreferrer">https://phabricator.kde.org/D2860</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
cmake/modules/KReportAddIconsRccFile.cmake<br />
cmake/modules/KReportMacros.cmake<br />
cmake/modules/update_icon_list.sh<br />
examples/CMakeLists.txt<br />
examples/main.cpp<br />
src/common/KReportPluginManager.cpp<br />
src/common/KReportSectionData.cpp<br />
src/common/KReportUtils_p.h<br />
src/items/check/check.json<br />
src/items/field/field.json<br />
src/items/image/image.json<br />
src/items/label/label.json<br />
src/items/text/text.json<br />
src/pics/CMakeLists.txt<br />
src/pics/hicolor/16-actions-kreport_checkbox_element.svg<br />
src/pics/hicolor/16-actions-kreport_field_element.svg<br />
src/pics/hicolor/16-actions-kreport_image_element.svg<br />
src/pics/hicolor/16-actions-kreport_label_element.svg<br />
src/pics/hicolor/16-actions-kreport_line_element.svg<br />
src/pics/hicolor/16-actions-kreport_text_element.svg<br />
src/pics/hicolor/22-actions-kreport_checkbox_element.svg<br />
src/pics/hicolor/22-actions-kreport_field_element.svg<br />
src/pics/hicolor/22-actions-kreport_image_element.svg<br />
src/pics/hicolor/22-actions-kreport_label_element.svg<br />
src/pics/hicolor/22-actions-kreport_line_element.svg<br />
src/pics/hicolor/22-actions-kreport_text_element.svg<br />
src/pics/hicolor/CMakeLists.txt<br />
src/pics/icons/breeze/actions/16/kreport-checkbox-element.svg<br />
src/pics/icons/breeze/actions/16/kreport-field-element.svg<br />
src/pics/icons/breeze/actions/16/kreport-image-element.svg<br />
src/pics/icons/breeze/actions/16/kreport-label-element.svg<br />
src/pics/icons/breeze/actions/16/kreport-line-element.svg<br />
src/pics/icons/breeze/actions/16/kreport-text-element.svg<br />
src/pics/icons/breeze/actions/22/kreport-checkbox-element.svg<br />
src/pics/icons/breeze/actions/22/kreport-field-element.svg<br />
src/pics/icons/breeze/actions/22/kreport-image-element.svg<br />
src/pics/icons/breeze/actions/22/kreport-label-element.svg<br />
src/pics/icons/breeze/actions/22/kreport-line-element.svg<br />
src/pics/icons/breeze/actions/22/kreport-text-element.svg<br />
src/pics/icons/breeze/files.cmake<br />
src/plugins/barcode/CMakeLists.txt<br />
src/plugins/barcode/kreport_barcodeplugin.json<br />
src/plugins/barcode/pics/CMakeLists.txt<br />
src/plugins/barcode/pics/hicolor/16-actions-kreport_barcode_element.svg<br />
src/plugins/barcode/pics/hicolor/22-actions-kreport_barcode_element.svg<br />
src/plugins/barcode/pics/hicolor/CMakeLists.txt<br />
src/plugins/barcode/pics/icons/breeze/actions/16/kreport-barcode-element.svg<br />
src/plugins/barcode/pics/icons/breeze/actions/22/kreport-barcode-element.svg<br />
src/plugins/barcode/pics/icons/breeze/files.cmake<br />
src/plugins/chart/CMakeLists.txt<br />
src/plugins/chart/kreport_chartplugin.json<br />
src/plugins/chart/pics/CMakeLists.txt<br />
src/plugins/chart/pics/hicolor/16-actions-kreport_chart_element.svg<br />
src/plugins/chart/pics/hicolor/22-actions-kreport_chart_element.svg<br />
src/plugins/chart/pics/hicolor/CMakeLists.txt<br />
src/plugins/chart/pics/icons/breeze/actions/16/kreport-chart-element.svg<br />
src/plugins/chart/pics/icons/breeze/actions/22/kreport-chart-element.svg<br />
src/plugins/chart/pics/icons/breeze/files.cmake<br />
src/plugins/maps/CMakeLists.txt<br />
src/plugins/maps/kreport_mapsplugin.json<br />
src/plugins/maps/pics/CMakeLists.txt<br />
src/plugins/maps/pics/hicolor/16-actions-kreport_maps_element.svg<br />
src/plugins/maps/pics/hicolor/22-actions-kreport_maps_element.svg<br />
src/plugins/maps/pics/hicolor/CMakeLists.txt<br />
src/plugins/maps/pics/icons/breeze/actions/16/kreport-maps-element.svg<br />
src/plugins/maps/pics/icons/breeze/actions/22/kreport-maps-element.svg<br />
src/plugins/maps/pics/icons/breeze/files.cmake<br />
src/plugins/web/CMakeLists.txt<br />
src/plugins/web/kreport_webplugin.json<br />
src/plugins/web/pics/CMakeLists.txt<br />
src/plugins/web/pics/hicolor/16-actions-kreport_web_element.svg<br />
src/plugins/web/pics/hicolor/22-actions-kreport_web_element.svg<br />
src/plugins/web/pics/hicolor/CMakeLists.txt<br />
src/plugins/web/pics/icons/breeze/actions/16/kreport-web-element.svg<br />
src/plugins/web/pics/icons/breeze/actions/22/kreport-web-element.svg<br />
src/plugins/web/pics/icons/breeze/files.cmake<br />
src/wrtembed/KReportDesigner.cpp<br />
src/wrtembed/KReportDesigner.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>staniek, piggz<br /><strong>Cc: </strong>Kexi-Devel-list, staniek<br /></div>