<div dir="ltr">@Staniek I pushed another commit sqlite should be working I guess. Could you run tests? I'm going outside for few hours<div>Would be cool if you could test it out. </div><div>I know coding would require coding-style etc still I would like to do it as the last thing when I have it working</div><div>In main CMakeLists.txt set qt5CmakeDirectory variable accordingly and it should work. If you could do this and let me</div><div>know about result would appreciate it :)</div><div><br>Best Regards,</div><div>Wojtek</div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-01-02 17:14 GMT+01:00 Jaroslaw Staniek <span dir="ltr"><<a href="mailto:staniek@kde.org" target="_blank">staniek@kde.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@Wojciech OK, for review please join (fixup) commits into bits that<br>
are functional and keeps coding standards.<br>
Can fail to link or compile though. No problem.<br>
<br>
@Boud Do you have recommendations you'd use during porting?<br>
<br>
@Wojciech For example things such as $QTBasicLibs are not typical.<br>
<br>
When porting let's look at KF5 libs for buildsystem standards and practices.<br>
I think guildelines from techbase such as<br>
<a href="https://community.kde.org/Frameworks/Porting_Notes" target="_blank">https://community.kde.org/Frameworks/Porting_Notes</a><br>
<br>
Look at example:<br>
<a href="http://quickgit.kde.org/?p=ktexteditor.git&a=blob&h=dd0dbf31f3b982ee9ca8a0f0b5891d6f0ad7843f&hb=fddd268459c301d92521b74a07fd84a1aff05a2d&f=src%2FCMakeLists.txt" target="_blank">http://quickgit.kde.org/?p=ktexteditor.git&a=blob&h=dd0dbf31f3b982ee9ca8a0f0b5891d6f0ad7843f&hb=fddd268459c301d92521b74a07fd84a1aff05a2d&f=src%2FCMakeLists.txt</a><br>
<br>
I know Predicate is Qt-only but a lot is in common.<br>
Also, there must be a few 3rd-party Qt5 libs that we can use as a<br>
reference too already.<br>
<div class="HOEnZb"><div class="h5"><br>
On 2 January 2015 at 16:57, Wojciech Kosowicz <<a href="mailto:pcellix@gmail.com">pcellix@gmail.com</a>> wrote:<br>
> Ok when I finish with sqlite Predicate (i am very close) will start sending<br>
> for review<br>
> For now I work on branch qt5-kosowicz and want to run tests after sqlite is<br>
> activated<br>
> I'm very close. When it's done will start reviewing and working on more<br>
> official branch<br>
> Having sqlite working would give opportunity to start parallel work. As if I<br>
> understand<br>
> correctly this a core :)<br>
><br>
> Best Regards,<br>
> Wojciech Kosowicz<br>
><br>
> 2015-01-02 16:52 GMT+01:00 Jaroslaw Staniek <<a href="mailto:staniek@kde.org">staniek@kde.org</a>>:<br>
>><br>
>> BTW, let's have a porting plan, i.e. document/record what scripts are<br>
>> to be executed, step by step.<br>
>><br>
>> On 2 January 2015 at 16:39, Wojciech Kosowicz <<a href="mailto:pcellix@gmail.com">pcellix@gmail.com</a>> wrote:<br>
>> > Another commit pushed, 3 things remaining for sqlite predicate port to<br>
>> > work:<br>
>> ><br>
>> > In SqliteDriver.cpp:36 commented out need to figure it out<br>
>> > Predicate/Driver.h Q_DECLARE_INTERFACE need to figue out<br>
>> > Predicate/EscapedString.h changes of qbool<br>
>> ><br>
>> ><br>
>> ><br>
>> > 2015-01-02 16:06 GMT+01:00 Wojciech Kosowicz <<a href="mailto:pcellix@gmail.com">pcellix@gmail.com</a>>:<br>
>> >><br>
>> >> Just made first commit at branch qt5-kosowicz of predicate repository.<br>
>> >> After making change in CMake setting one variable accordingly to your<br>
>> >> system. It should built<br>
>> >> Any idea how will do review here? :)<br>
>> >><br>
>> >> 2015-01-02 14:04 GMT+01:00 Wojciech Kosowicz <<a href="mailto:pcellix@gmail.com">pcellix@gmail.com</a>>:<br>
>> >>><br>
>> >>> Ok I got round 40% compiling I push it to branch on Predicate<br>
>> >>> qt5-kosowicz branch now with this as initial commit<br>
>> >>><br>
>> >>> 2015-01-02 13:33 GMT+01:00 Jaroslaw Staniek <<a href="mailto:staniek@kde.org">staniek@kde.org</a>>:<br>
>> >>>><br>
>> >>>> On 2 January 2015 at 13:02, Jaroslaw Staniek <<a href="mailto:staniek@kde.org">staniek@kde.org</a>> wrote:<br>
>> >>>> > On 2 January 2015 at 12:56, Wojciech Kosowicz <<a href="mailto:pcellix@gmail.com">pcellix@gmail.com</a>><br>
>> >>>> > wrote:<br>
>> >>>> >> Hello,<br>
>> >>>> >> Today I'm starting to port Predicate to Qt5. As I see there are no<br>
>> >>>> >> KDElibs<br>
>> >>>> >> required therefore only might appear issues of introducing changes<br>
>> >>>> >> from qt5.<br>
>> >>>> >> After it builds on Linux I'll start building it on Mac Os.<br>
>> >>>> ><br>
>> >>>> > Cool!<br>
>> >>>> > Please use your branch such as qt5-kosowicz.<br>
>> >>>> > A good verification after porting (except for "it compiles and<br>
>> >>>> > links")<br>
>> >>>> > is to:<br>
>> >>>> > 1. run "ctest" in the build dir.<br>
>> >>>> > 2. try manual tests at tests/features/.<br>
>> >>>> ><br>
>> >>>> > First please check if these tests work for you in case of Qt4<br>
>> >>>> > version.<br>
>> >>>> ><br>
>> >>>> > CC'd to calligra-devel, as this is a part of porting-to-Qt5<br>
>> >>>> > activity.<br>
>> >>>><br>
>> >>>> ^Forgot to CC.<br>
>> >>>><br>
>> >>>> --<br>
>> >>>> regards, Jaroslaw Staniek<br>
>> >>>><br>
>> >>>> KDE:<br>
>> >>>> : A world-wide network of software engineers, artists, writers,<br>
>> >>>> translators<br>
>> >>>> : and facilitators committed to Free Software development -<br>
>> >>>> <a href="http://kde.org" target="_blank">http://kde.org</a><br>
>> >>>> Calligra Suite:<br>
>> >>>> : A graphic art and office suite - <a href="http://calligra.org" target="_blank">http://calligra.org</a><br>
>> >>>> Kexi:<br>
>> >>>> : A visual database apps builder - <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a><br>
>> >>>> Qt Certified Specialist:<br>
>> >>>> : <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a><br>
>> >>><br>
>> >>><br>
>> >><br>
>> ><br>
>><br>
>><br>
>><br>
>> --<br>
>> regards, Jaroslaw Staniek<br>
>><br>
>> KDE:<br>
>> : A world-wide network of software engineers, artists, writers,<br>
>> translators<br>
>> : and facilitators committed to Free Software development - <a href="http://kde.org" target="_blank">http://kde.org</a><br>
>> Calligra Suite:<br>
>> : A graphic art and office suite - <a href="http://calligra.org" target="_blank">http://calligra.org</a><br>
>> Kexi:<br>
>> : A visual database apps builder - <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a><br>
>> Qt Certified Specialist:<br>
>> : <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a><br>
><br>
><br>
<br>
<br>
<br>
--<br>
regards, Jaroslaw Staniek<br>
<br>
KDE:<br>
: A world-wide network of software engineers, artists, writers, translators<br>
: and facilitators committed to Free Software development - <a href="http://kde.org" target="_blank">http://kde.org</a><br>
Calligra Suite:<br>
: A graphic art and office suite - <a href="http://calligra.org" target="_blank">http://calligra.org</a><br>
Kexi:<br>
: A visual database apps builder - <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a><br>
Qt Certified Specialist:<br>
: <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a><br>
</div></div></blockquote></div><br></div>