<table><tr><td style="">alexeymin created this revision.<br />Herald added a project: KDevelop.<br />Herald added a subscriber: kdevelop-devel.<br />alexeymin requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24914">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Trying to build kdevelop-pg-qt with Qt 5.14 results in an error:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">.../kdev-pg/kdev-pg-regexp.cpp:44:23: error: redefinition of ‘struct std::hash<QBitArray>’
     template<> struct hash< type >                          \
                       ^~~~~~~~~~~~
.../kdev-pg/kdev-pg-regexp.cpp:53:1: note: in expansion of macro ‘q_Hash_to_tr1_hash’
 q_Hash_to_tr1_hash(QBitArray)
 ^~~~~~~~~~~~~~~~~~
In file included from .../prefix514/include/QtCore/qvector.h:47:0,
                 from .../prefix514/include/QtCore/QVector:1,
                 from .../kdevelop-pg-qt/include/kdev-pg-char-sets.h:36,
                 from .../kdevelop-pg-qt/kdev-pg/kdev-pg-regexp.cpp:20:
.../prefix514/include/QtCore/qhashfunctions.h:209:1: note: previous definition of ‘struct std::hash<QBitArray>’
 QT_SPECIALIZE_STD_HASH_TO_CALL_QHASH_BY_CREF(QBitArray)
 ^</pre></div>

<p>std::hash<QBitArray> is already specialized in Qt 5.14, so avoid redefinition with conditional compilation</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>try to build with Qt 5.14</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R51 KDevelop: PG Qt</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-build-qt514</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24914">https://phabricator.kde.org/D24914</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kdev-pg/kdev-pg-regexp.cpp</div></div></div><br /><div><strong>To: </strong>alexeymin<br /><strong>Cc: </strong>kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>