<table><tr><td style="">simgunz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21156">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D21156#486717" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D21156#486717</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>If you're not using arc you should have included the "Differential Revision" line in the commit so it would close automatically as stated in <a href="https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages</a></p>

<p>I'll close this manually for you :)</p></div>
</blockquote>

<p>In the phabricator guide it is suggested to push manually when the target branch in not master:</p>

<p><a href="https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22</a></p>

<p>Wouldn't make more sense to do <tt style="background: #ebebeb; font-size: 13px;">arc land --onto 5.3</tt> (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically.</p>

<p>Final question: for discussing things like this, regarding the <a href="https://community.kde.org" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org</a> guides, what is the most appropriate place? Opening a discussion on the Wiki page? Or is it therea bugs.kde.org section for this (I could not find an obvious one).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21156">https://phabricator.kde.org/D21156</a></div></div><br /><div><strong>To: </strong>simgunz, KDevelop, rjvbb, mwolff<br /><strong>Cc: </strong>aacid, kde-doc-english, mwolff, rjvbb, kdevelop-devel, hmitonneau, christiant, gennad, fbampaloukas, glebaccon, domson, antismap, iodelay, alexeymin, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>