<table><tr><td style="">mwolff accepted this revision.<br />mwolff added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17908">View Revision</a></tr></table><br /><div><div><p>you can pick whatever you prefer for the reviews for now.</p>

<p>do you have commit rights? if so, please feel free to push this directly, otherwise someone from us can take care of that for you</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17908#inline-103056">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevelop-msvc.bat:8</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #aa4000"><span class="bright">IF</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">NOT</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">DEFINED</span></span><span class="bright"> </span><span style="color: #001294"><span class="bright">VS150COMNTOOLS</span></span> <span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #74777d"><span class="bright">REM load Visual Studio 2017 developer command prompt if VS150COMNTOOLS is not set. It's ugly and hardcoded too.</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> </span><span style="color: #bb6622"><span class="bright">%%</span></span><span class="bright">n </span><span style="color: #aa4000"><span class="bright">in</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright">Enterprise Professional </span>Comm<span class="bright">unity Build</span>Tools<span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">do</span></span> <span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">/f</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"usebackq tokens=3*"</span></span><span class="bright"> </span><span style="color: #bb6622"><span class="bright">%%</span></span><span class="bright">a </span><span style="color: #aa4000"><span class="bright">in</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">`reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7" /s`</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">do</span></span> <span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"> </span><span style="color: #aa4000"><span class="bright">set</span></span><span class="bright"> </span><span style="color: #001294"><span class="bright">vs15_path</span></span><span class="bright"></span><span class="p"><span class="bright">=</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">%%</span></span><span class="bright">a </span><span style="color: #bb6622"><span class="bright">%%</span></span><span class="bright">b</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"> </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">exist</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">!vs15_path!</span></span><span style="color: #766510">Comm<span class="bright">on7\</span>Tools<span class="bright">\VsDevCmd.bat"</span></span> <span class="p">(</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">is vs15 visual studio 2017? I'm always confused by the versioning scheme of visual studio :D</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17908">https://phabricator.kde.org/D17908</a></div></div><br /><div><strong>To: </strong>Petross404, KDevelop, kfunk, brauch, mwolff<br /><strong>Cc: </strong>mwolff, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>