<table><tr><td style="">mwolff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5447">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5447#399310" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D5447#399310</a>, <a href="https://phabricator.kde.org/p/arrowd/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@arrowd</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5447#399235" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D5447#399235</a>, <a href="https://phabricator.kde.org/p/mwolff/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mwolff</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>the path of the compiler is now always the path of the compiler in the local host, which breaks when you have a runtime with a different setup.</p></div>
</blockquote>
<p>Hum. Before being passed to <tt style="background: #ebebeb; font-size: 13px;">rt->pathInHost()</tt>, the compiler path gets wrapped into <tt style="background: #ebebeb; font-size: 13px;">KDevelop::Path</tt>. Doesn't this make it absolute/invalid? Judging from <tt style="background: #ebebeb; font-size: 13px;">Path::Path(QString)</tt> constructor, it should't even accept things like <tt style="background: #ebebeb; font-size: 13px;">"gcc"</tt>.</p>
<p>And what are we checking there? I still don't make any sense from this check.</p></div>
</blockquote>
<p>you are right, this code should essentially do <tt style="background: #ebebeb; font-size: 13px;">if (rt->findExecutable(compiler->path().isEmpty()) continue;</tt>, could you introduce that please?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>So, the question really is: Why was the code inloc 213 in <tt style="background: #ebebeb; font-size: 13px;">compilerprovider.cpp</tt> not working for you? If <tt style="background: #ebebeb; font-size: 13px;">gcc</tt> wasn't installed, we should get:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">compiler->path() == "gcc"</tt>, i.e. not absolute</li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">QStandardpaths::findExecutable("gcc", path)</tt> should always return false for all the entries in your <tt style="background: #ebebeb; font-size: 13px;">PATH</tt></li>
<li class="remarkup-list-item">we should thus never set the gcc compiler
<br /><br />
please debug why the above didn't work for you</li>
</ul></blockquote>
<p>Are you talking about old code? Then it is not <tt style="background: #ebebeb; font-size: 13px;">QStandardpaths::findExecutable("gcc", path)</tt> that doesn't work for me, it is <tt style="background: #ebebeb; font-size: 13px;">QFileInfo::exists(rt->pathInHost())</tt> part. Why do we skip adding a compiler if it <strong>does</strong> exist?</p></blockquote>
</div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5447#inline-102955">View Inline</a><span style="color: #4b4d51; font-weight: bold;">compilerprovider.cpp:214</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">absolutePath</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QDir</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">isAbsolute</span>Path</span><span class="p">(</span><span class="n">compiler</span><span style="color: #aa2211">-></span><span class="n">path</span><span class="p">())<span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">((</span></span><span class="bright"></span><span class="n"><span class="bright">absolute</span>Path<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span class="n">QFileInfo<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">exists</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">rt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">pathInHost</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">Path</span></span><span class="p">(</span><span class="n">compiler</span><span style="color: #aa2211">-></span><span class="n">path</span><span class="p">())<span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">toLocalFile</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa2211">||</span> <span class="n">QStandardPaths</span><span style="color: #aa2211">::</span><span class="n">findExecutable</span><span class="p">(</span> <span class="n">compiler</span><span style="color: #aa2211">-></span><span class="n">path</span><span class="p">(),</span> <span class="n">path</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span class="n"><span class="bright">QFileInfo</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">exists</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">rt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">pathInHost</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">Path</span><span class="p">(</span><span class="n">compiler</span><span style="color: #aa2211">-></span><span class="n">path</span><span class="p">())<span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">toLocalFile</span></span><span class="bright"></span><span class="p"><span class="bright">())</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">QStandard</span>Path<span class="bright">s</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">findExecutable</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">QFileInfo</span><span class="p">(</span><span class="n">compiler</span><span style="color: #aa2211">-></span><span class="n">path</span><span class="p">())<span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">fileName</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">rtPaths</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">isEmpty</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you are right - the issue is that the old code skips compilers when they exist - there's a ! missing in front of the parens here probably</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5447">https://phabricator.kde.org/D5447</a></div></div><br /><div><strong>To: </strong>arrowd, mwolff, arichardson<br /><strong>Cc: </strong>skalinichev, apol, kdevelop-devel<br /></div>