<table><tr><td style="">kfunk accepted this revision.<br />kfunk added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16773">View Revision</a></tr></table><br /><div><div><p>LGTM in general. If you prefer your version (instead of the one proposed by me) feel free to push directly.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16773#inline-94793">View Inline</a><span style="color: #4b4d51; font-weight: bold;">context.cpp:186</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">project</span><span style="color: #aa2211">-></span><span class="n">filesForPath</span><span class="p">(</span><span class="n">IndexedString</span><span class="p">(</span><span class="n">view</span><span style="color: #aa2211">-></span><span class="n">document</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">url</span><span class="p">().</span><span class="n">path</span><span class="p">())).</span><span class="n">first</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">match</span> <span style="color: #aa2211">=</span> <span class="n">QRegularExpression</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span class="n">R</span><span style="color: #766510">"(-std=c\+\+(\d+))"</span><span class="p">)).</span><span class="n">match</span><span class="p">(</span><span class="n">arguments</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The correct way to capture this would probably be <tt style="background: #ebebeb; font-size: 13px;">-std=c\+\+(\w+)</tt>, to also capture potential things like "-std=c++1x" (though you don't check that here). Still feels cleaner.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16773#inline-94794">View Inline</a><span style="color: #4b4d51; font-weight: bold;">context.cpp:191</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">standard</span> <span style="color: #aa2211">=</span> <span class="n">match</span><span class="p">.</span><span class="n">captured</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">).</span><span class="n">toInt</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">appendSpecifer</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">standard</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">98</span> <span style="color: #aa2211">&&</span> <span class="n">standard</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">3</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">And consecutively here: <tt style="background: #ebebeb; font-size: 13px;">(standard != "98" && standard != "03")</tt></p>

<p style="padding: 0; margin: 8px;">Was a little confused by the <tt style="background: #ebebeb; font-size: 13px;">3</tt> here at first. I think the string version makes it clearer.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16773#inline-94795">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_codecompletion.cpp:1479</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa2211"><<</span> <span style="color: #766510">"class Foo { int** bar(int x); };</span><span style="color: #bb6622">\n</span><span style="color: #766510">int ** Foo::bar(int x)</span><span style="color: #bb6622">\n</span><span style="color: #766510">{</span><span style="color: #bb6622">\n</span><span style="color: #766510">}</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>config-override</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16773">https://phabricator.kde.org/D16773</a></div></div><br /><div><strong>To: </strong>amhndu, kfunk<br /><strong>Cc: </strong>kfunk, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>