<table><tr><td style="">kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16461">View Revision</a></tr></table><br /><div><div><p>I wonder if a couple of <tt style="background: #ebebeb; font-size: 13px;">auto* element = it->element</tt>, <tt style="background: #ebebeb; font-size: 13px;">auto* staticProperty = it->element->staticProperty</tt> sprayed throughout the code base would help making all of  this a bit more readable...</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16461#inline-92220">View Inline</a><span style="color: #4b4d51; font-weight: bold;">uses.cpp:1423</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">dec</span><span style="color: #aa2211">-></span><span class="n">identifier</span><span class="p">(),</span> <span class="n">Identifier</span><span class="p">(</span><span style="color: #766510">"a"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">compareUses</span><span class="p">(</span><span class="n">dec</span><span class="p">,</span> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">RangeInRevision</span><span style="color: #aa2211">></span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa2211"><<</span> <span class="n">RangeInRevision</span><span class="p">(</span><span style="color: #601200">3</span><span class="p">,</span> <span style="color: #601200">9</span><span class="p">,</span> <span style="color: #601200">3</span><span class="p">,</span> <span style="color: #601200">10</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Minor, for future: you can use C++11-style initialization here: <tt style="background: #ebebeb; font-size: 13px;">QList<RangeInRevision>{...}</tt></p>

<p style="padding: 0; margin: 8px;">More TODO: Should be a <tt style="background: #ebebeb; font-size: 13px;">QVector<RangeInRevision></tt> for performance reasons.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R52 KDevelop: PHP Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16461">https://phabricator.kde.org/D16461</a></div></div><br /><div><strong>To: </strong>pprkut, kfunk<br /><strong>Cc: </strong>kfunk, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>