<table><tr><td style="">brauch added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16203">View Revision</a></tr></table><br /><div><div><p>I think the change conceptually makes sense, and I am subconsciously aware of the bug it is trying to fix. If you say it works for you, it should be fine.</p>

<p>It is a binary- and source-incompatible change for plugins though. Did you check whether the potentially affected plugins need source changes?</p>

<p>It's not great style to do such a change so shortly before the release from the release management point of view, but since realistically there exist no external plugins, we probably shouldn't worry too much about that ...</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16203#inline-88484">View Inline</a><span style="color: #4b4d51; font-weight: bold;">contextbrowser.cpp:556</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">QWidget</span><span style="color: #aa2211">*</span> <span class="n">ContextBrowserPlugin</span><span style="color: #aa2211">::</span><span class="n">navigationWidgetForPosition</span><span class="p">(</span><span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">View</span><span style="color: #aa2211">*</span> <span class="n">view</span><span class="p">,</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Cursor</span> <span class="n">position<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QWidget</span><span style="color: #aa2211">*</span> <span class="n">ContextBrowserPlugin</span><span style="color: #aa2211">::</span><span class="n">navigationWidgetForPosition</span><span class="p">(</span><span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">View</span><span style="color: #aa2211">*</span> <span class="n">view</span><span class="p">,</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Cursor</span> <span class="n">position<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                           <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Range</span><span style="color: #aa2211">&</span> <span class="n">itemRange</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In the API, you return a tuple for this use case, here you use a return argument instead. I think you should return a tuple here as well.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16203">https://phabricator.kde.org/D16203</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop<br /><strong>Cc: </strong>brauch, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>