<table><tr><td style="">kossebau updated this revision to Diff 43224.<br />kossebau edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-3arureq5kmfpbcl/">(Show Details)</a><br />kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16032">View Revision</a></tr></table><br /><div><div><p>update to latest master</p>
<p>Also simplify call interface even more, by now adding pairs of custom declare &<br />
install macros:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">for kdevplatform:<ul class="remarkup-list">
<li class="remarkup-list-item">declare_platformlib_qt_logging_category</li>
<li class="remarkup-list-item">install_platformlib_qt_logging_categories</li>
</ul></li>
<li class="remarkup-list-item">for plugins & app:<ul class="remarkup-list">
<li class="remarkup-list-item">declare_plugin_qt_logging_category</li>
<li class="remarkup-list-item">declare_app_qt_logging_category</li>
<li class="remarkup-list-item">install_app_plugin_qt_logging_categories</li>
</ul></li>
</ul>
<p>Those pairs avoid the need for the manual linking between declare & install<br />
by the EXPORT id, which now is handled by the custom macros internally.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">declare_platformlib_qt_logging_category(KDevPlatformShell_LIB_SRCS
CATEGORY_BASENAME "shell"
)</pre></div>
<p>and</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">declare_plugin_qt_logging_category(kdevclazy_core_SRCS
IDENTIFIER KDEV_CLAZY
CATEGORY_BASENAME "clazy"
)</pre></div>
<p>with the respective categories file creation and installation calls being:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">install_platformlib_qt_logging_categories()</pre></div>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">install_app_plugin_qt_logging_categories()</pre></div></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>then used both for plugins and the kdevplatform libraries.<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br />
</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D16032?vs=43093&id=43224">https://phabricator.kde.org/D16032?vs=43093&id=43224</a></div></div><br /><div><strong>BRANCH</strong><div><div>morecategoriesgeneration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16032">https://phabricator.kde.org/D16032</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
app/CMakeLists.txt<br />
cmake/modules/KDevelopMacrosInternal.cmake<br />
kdevelop.categories<br />
kdevplatform/CMakeLists.txt<br />
kdevplatform/debugger/CMakeLists.txt<br />
kdevplatform/documentation/CMakeLists.txt<br />
kdevplatform/language/CMakeLists.txt<br />
kdevplatform/outputview/CMakeLists.txt<br />
kdevplatform/project/CMakeLists.txt<br />
kdevplatform/serialization/CMakeLists.txt<br />
kdevplatform/shell/CMakeLists.txt<br />
kdevplatform/sublime/CMakeLists.txt<br />
kdevplatform/util/CMakeLists.txt<br />
kdevplatform/vcs/CMakeLists.txt<br />
plugins/android/CMakeLists.txt<br />
plugins/appwizard/CMakeLists.txt<br />
plugins/astyle/CMakeLists.txt<br />
plugins/clang/CMakeLists.txt<br />
plugins/clang/util/clangdebug.cpp<br />
plugins/clangtidy/CMakeLists.txt<br />
plugins/classbrowser/CMakeLists.txt<br />
plugins/clazy/CMakeLists.txt<br />
plugins/cmake/CMakeLists.txt<br />
plugins/cmakebuilder/CMakeLists.txt<br />
plugins/codeutils/CMakeLists.txt<br />
plugins/contextbrowser/CMakeLists.txt<br />
plugins/cppcheck/CMakeLists.txt<br />
plugins/custom-buildsystem/CMakeLists.txt<br />
plugins/custom-definesandincludes/CMakeLists.txt<br />
plugins/custommake/CMakeLists.txt<br />
plugins/customscript/CMakeLists.txt<br />
plugins/cvs/CMakeLists.txt<br />
plugins/debuggercommon/CMakeLists.txt<br />
plugins/docker/CMakeLists.txt<br />
plugins/documentswitcher/CMakeLists.txt<br />
plugins/execute/CMakeLists.txt<br />
plugins/executeplasmoid/CMakeLists.txt<br />
plugins/executescript/CMakeLists.txt<br />
plugins/externalscript/CMakeLists.txt<br />
plugins/filemanager/CMakeLists.txt<br />
plugins/filetemplates/CMakeLists.txt<br />
plugins/flatpak/CMakeLists.txt<br />
plugins/gdb/CMakeLists.txt<br />
plugins/ghprovider/CMakeLists.txt<br />
plugins/git/CMakeLists.txt<br />
plugins/grepview/CMakeLists.txt<br />
plugins/heaptrack/CMakeLists.txt<br />
plugins/konsole/CMakeLists.txt<br />
plugins/lldb/CMakeLists.txt<br />
plugins/makebuilder/CMakeLists.txt<br />
plugins/ninjabuilder/CMakeLists.txt<br />
plugins/outlineview/CMakeLists.txt<br />
plugins/patchreview/CMakeLists.txt<br />
plugins/perforce/CMakeLists.txt<br />
plugins/problemreporter/CMakeLists.txt<br />
plugins/projectfilter/CMakeLists.txt<br />
plugins/projectmanagerview/CMakeLists.txt<br />
plugins/qmakebuilder/CMakeLists.txt<br />
plugins/qmakemanager/CMakeLists.txt<br />
plugins/qmljs/CMakeLists.txt<br />
plugins/qmljs/duchain/CMakeLists.txt<br />
plugins/qthelp/CMakeLists.txt<br />
plugins/quickopen/CMakeLists.txt<br />
plugins/standardoutputview/CMakeLists.txt<br />
plugins/subversion/CMakeLists.txt<br />
plugins/switchtobuddy/CMakeLists.txt<br />
plugins/testview/CMakeLists.txt<br />
plugins/welcomepage/CMakeLists.txt</div></div></div><br /><div><strong>To: </strong>kossebau, KDevelop<br /><strong>Cc: </strong>apol, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>