<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a subscriber: mwolff.<br />kfunk added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15895">View Revision</a></tr></table><br /><div><div><p>But I think in general that approach makes more sense. Thanks for working on it.</p>
<p>Comments from <a href="https://phabricator.kde.org/p/mwolff/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mwolff</a> would be appreciated, too, since he worked on that feature to begin with.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15895#inline-86266">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindClang.cmake:92</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">CLANG_LIBRARY_DIRS</span> <span style="color: #aa2211">${</span><span style="color: #001294">LLVM_LIBRARY_DIRS</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">CLANG_INCLUDE_DIRS</span> <span style="color: #aa2211">${</span><span style="color: #001294">LLVM_INCLUDE_DIRS</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">CLANG_VERSION</span> <span style="color: #aa2211">${</span><span style="color: #001294">LLVM_VERSION</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">IIUC then <tt style="background: #ebebeb; font-size: 13px;">CLANG_INCLUDE_DIRS</tt> shouldn't be touched. <tt style="background: #ebebeb; font-size: 13px;">CLANG_INCLUDE_DIRS</tt> is for finding the correct include dirs for building KDevClangSupport against libclang -- we don't need to have things like compiler builtin includes in there.</p>
<p style="padding: 0; margin: 8px;">Rather, leave <tt style="background: #ebebeb; font-size: 13px;">CLANG_INCLUDE_DIRS</tt> as it is and do <tt style="background: #ebebeb; font-size: 13px;">find_path(CLANG_BUILTIN_DIR ...)</tt>, in other words: create another variable.</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/buschinski/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@buschinski</a> Just to double-check: /usr/lib64/llvm/7/include has a <tt style="background: #ebebeb; font-size: 13px;">clang</tt> subfolder on Gentoo, right?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15895#inline-86267">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindClang.cmake:104</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">NOT</span> <span style="color: #766510">CLANG_INCLUDE_DIRS</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">message</span><span class="p">(</span><span style="color: #766510">FATAL_ERROR</span> <span style="color: #766510">"Unabled to find the include file cpuid.h from clang."</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">endif</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Typo: "Unabled"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15895">https://phabricator.kde.org/D15895</a></div></div><br /><div><strong>To: </strong>buschinski, KDevelop, kfunk<br /><strong>Cc: </strong>mwolff, aaronpuchert, brauch, kossebau, kfunk, arrowd, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight<br /></div>