<table><tr><td style="">flherne requested changes to this revision.<br />flherne added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15743">View Revision</a></tr></table><br /><div><div><p>This looks good to me overall, but see a few inline comments.</p>

<p>I've tried various awkward cases with the current patch, and it seems to work fine!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15743#inline-85222">View Inline</a><span style="color: #4b4d51; font-weight: bold;">amhndu</span> wrote in <span style="color: #4b4d51; font-weight: bold;">externalscriptplugin.cpp:392</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Would this better be a member ?<br />
Will save the time required to create a new set each call.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We don't need this at all, it's effectively a reimplementation of <a href="https://api.kde.org/frameworks/kconfig/html/classKConfigGroup.html#a1f776ccf3815c32e84c0816403e249b6" class="remarkup-link" target="_blank" rel="noreferrer">KConfigGroup::groupList()</a>.</p>

<p style="padding: 0; margin: 8px;">In principle yours is more efficient for this purpose (doesn't needlessly convert the set to a list), but the number of external-scripts will never be large enough for that to matter.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15743#inline-85494">View Inline</a><span style="color: #4b4d51; font-weight: bold;">externalscriptplugin.cpp:406</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">int</span> <span class="n">maxSuffix</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">keyCandidate</span> <span style="color: #aa2211">=</span> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span> <span class="n">maxSuffix</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(;</span> <span class="n">keySet</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span> <span class="n">keyCandidate</span> <span class="p">);</span> <span style="color: #aa2211">++</span><span class="n">maxSuffix</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd prefer if this line was just <tt style="background: #ebebeb; font-size: 13px;">keyCandidate = item->text()</tt>, and have <tt style="background: #ebebeb; font-size: 13px;">maxSuffix</tt> initialised to 2.</p>

<p style="padding: 0; margin: 8px;">Scripts will almost always have unique names, because users don't want to confuse themselves, and it would be tidier not to have a suffix for the normal case.<br />
That would give us:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">[Thing]</li>
<li class="remarkup-list-item">[Thing2]</li>
</ul>

<p style="padding: 0; margin: 8px;">rather than</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">[Thing0]</li>
<li class="remarkup-list-item">[Thing1]</li>
</ul></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15743#inline-85489">View Inline</a><span style="color: #4b4d51; font-weight: bold;">externalscriptplugin.h:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span style="color: #aa4000">void</span> <span class="bright"></span><span style="color: #004012"><span class="bright">sav</span>eItem</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">ExternalScriptItem</span><span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">void</span> <span class="bright"></span><span style="color: #004012"><span class="bright">updat</span>eItem</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">ExternalScriptItem</span><span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why do you rename <tt style="background: #ebebeb; font-size: 13px;">save</tt> -> <tt style="background: #ebebeb; font-size: 13px;">update</tt> everywhere? To me that implies the opposite action, updating the item from a modified config.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15743">https://phabricator.kde.org/D15743</a></div></div><br /><div><strong>To: </strong>amhndu, KDevelop, flherne<br /><strong>Cc: </strong>flherne, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>