<table><tr><td style="">aaronpuchert added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15764">View Revision</a></tr></table><br /><div><div><p>So I think there are two questions to decide here:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Do we want a <tt style="background: #ebebeb; font-size: 13px;">-std=</tt> flag, does Clang even accept that?</li>
<li class="remarkup-list-item">Should we just take the <tt style="background: #ebebeb; font-size: 13px;">ObjC</tt> flags from the <tt style="background: #ebebeb; font-size: 13px;">C</tt> flags, and <tt style="background: #ebebeb; font-size: 13px;">ObjC++</tt> flags from the <tt style="background: #ebebeb; font-size: 13px;">C++</tt> flags, or should they be set independently?</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15764#inline-85252">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gcclikecompiler.cpp:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// no -std= flag passed -> assume c++11</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span style="color: #004012">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"-std=c++11"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">type</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span class="n"><span class="bright">Utils</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Cpp</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">type</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span class="n"><span class="bright">Utils</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">ObjCpp</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"-std=c++11<span class="bright">"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does ObjC++ not have a <tt style="background: #ebebeb; font-size: 13px;">-std=</tt> flag?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15764#inline-85253">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingsmanager.cpp:74-75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">return</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"parserArgumentsCuda"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// TODO: is there a need for "parserArgumentsObjC[++]" and if so how/where</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// if not, merge the ObjC cases with the C/C++ cases.</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">case</span> <span class="n">Utils</span><span style="color: #aa2211">::</span><span style="color: #a0a000">ObjC</span><span class="p">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do you want to be able to define custom parser arguments? As above, are there multiple standards or language versions of ObjC++? I'd guess so if it is based on C++.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15764#inline-85256">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingsmanager.cpp:108</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">arguments</span><span class="p">[</span><span class="n">Utils</span><span style="color: #aa2211">::</span><span class="n">ObjC</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"-ferror-limit=100 -fspell-checking -Wdocumentation -Wunused-parameter -Wunreachable-code -Wall<span class="bright"> -std=c99</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">arguments</span><span class="p">[</span><span class="n">Utils</span><span style="color: #aa2211">::</span><span class="n">ObjC</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"-ferror-limit=100 -fspell-checking -Wdocumentation -Wunused-parameter -Wunreachable-code -Wall"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">arguments</span><span class="p">[</span><span class="n">Utils</span><span style="color: #aa2211">::</span><span class="n">ObjCpp</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">arguments</span><span class="p">[</span><span class="n">Utils</span><span style="color: #aa2211">::</span><span class="n">Cpp</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">arguments</span><span class="p">.</span><span class="n">parseAmbiguousAsCPP</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since we didn't copy the <tt style="background: #ebebeb; font-size: 13px;">C</tt> string for <tt style="background: #ebebeb; font-size: 13px;">ObjC</tt>, we should similarly not tie <tt style="background: #ebebeb; font-size: 13px;">Cpp</tt> and <tt style="background: #ebebeb; font-size: 13px;">ObjCpp</tt> together. Unless there is a good reason to do that. But then we should do the same for <tt style="background: #ebebeb; font-size: 13px;">C</tt> and <tt style="background: #ebebeb; font-size: 13px;">ObjC</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15764#inline-85254">View Inline</a><span style="color: #4b4d51; font-weight: bold;">parserwidget.cpp:61</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">case</span> <span class="n">Utils</span><span style="color: #aa2211">::</span><span style="color: #a0a000">ObjCpp</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"c++11"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">case</span> <span class="n">Utils</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Other</span><span class="p">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">So here you say <tt style="background: #ebebeb; font-size: 13px;">c++11</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15764">https://phabricator.kde.org/D15764</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop<br /><strong>Cc: </strong>aaronpuchert, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>