<table><tr><td style="">aaronpuchert added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15532">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D15532#329308" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D15532#329308</a>, <a href="https://phabricator.kde.org/p/rjvbb/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rjvbb</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>We could activate <tt style="background: #ebebeb; font-size: 13px;">-Wunreachable-code</tt> so the compiler tells you where <tt style="background: #ebebeb; font-size: 13px;">break</tt> isn't needed.</p></blockquote>
<p>Evidently I was talking about a general principle, not about introducing a dependency on the compiler telling you what (not) to do. If I wanted that I'd be coding in Modula-2 ...</p></div>
</blockquote>
<p>Eventually we have to compile our code anyway, so aren't we all dependent on the compiler? I'm not sure why you're bringing Modula-2 into the discussion, but C++ is very much about compile-time analysis, in fact I'd say it's one of the main reasons to use it. (Also because it's fast, but that has something to do with compile-time analysis as well.)</p>
<p>With KDevelop's nice integration of compiler warnings it usually doesn't hurt to turn on <tt style="background: #ebebeb; font-size: 13px;">-Weverything</tt>. It helps me see a lot of issues that I'd probably overlook otherwise.</p>
<p>If you don't want your compiler to tell you what (not) to do, use a language that isn't compiled.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15532#inline-84391">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kossebau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">astyle_plugin.cpp:36</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Not yet firm with constexpr myself, so curious to learn what would one gain from using <tt style="background: #ebebeb; font-size: 13px;">static constexpr char[]</tt> here? What exactly would be buildtime evaluated?<br />
I think I have seen constexpr already in KDevelop code, so if that is a better version, would be interested to improve all similar places.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Basically <tt style="background: #ebebeb; font-size: 13px;">constexpr</tt> forces compile-time evaluation, which means that</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">The variable will (almost certainly) land in a read-only segment.</li>
<li class="remarkup-list-item">There is no dynamic initialization order fiasco.</li>
</ol>
<p style="padding: 0; margin: 8px;">In this case it wouldn't make much of a difference, since it is a compile-time constant and the compiler will treat is as such. But with <tt style="background: #ebebeb; font-size: 13px;">constexpr</tt> you get a compilation error if it isn't.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15532">https://phabricator.kde.org/D15532</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop, kossebau, kfunk<br /><strong>Cc: </strong>aaronpuchert, kfunk, pino, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>