<table><tr><td style="">antonanikin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15326">View Revision</a></tr></table><br /><div><div><p>Hi, Friedrich. Simple detaching doesn't remove segfaults. Current version also keep segfaults :(</p>
<p>Steps to reproduce:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Start KDevelop and load some project</li>
<li class="remarkup-list-item">Start project build</li>
<li class="remarkup-list-item">Type something in the build output view filter edit</li>
<li class="remarkup-list-item">Close KDevelop</li>
<li class="remarkup-list-item">Segfault happens</li>
</ol>
<p>It's happens because proxy model destroyed before our destructor by upper-levels (see backtrace later). So I suggest to completely drop <tt style="background: #ebebeb; font-size: 13px;">QSharedPointer</tt> since it's usage here is overkill and produce very fragile code.</p>
<p>We can use plain pointers as in my first revision - it works well without memleaks and segfaults. I'll add code to destroy our model+model on output removing (see first message from <a href="https://phabricator.kde.org/p/vkorneev/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@vkorneev</a>) and publish new revision (which will be "old" first variant :) )</p>
<p>Backtrace of proxy model destroy (catched with qick and dirty hack <br />
<tt style="background: #ebebeb; font-size: 13px;">connect(proxyModel, &QObject::destroyed, this, []() { qDebug() << "proxyModel::destroyed" << 1/0; });</tt>):</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#0 0x00007fffa22e4a63 in QDebug::maybeSpace() (this=<optimized out>) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qdebug.h:125
#1 0x00007fffa22e4a63 in QDebug::operator<<(char const*) (t=<optimized out>, this=<optimized out>)
at /usr/include/x86_64-linux-gnu/qt5/QtCore/qdebug.h:153
#2 0x00007fffa22e4a63 in OutputWidget::<lambda()>::operator() (__closure=<optimized out>)
at /home/htower/develop/kde_qt/kdevelop/plugins/standardoutputview/outputwidget.cpp:679
#3 0x00007fffa22e4a63 in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, OutputWidget::outputFilter(const QString&)::<lambda()> >::call (f=..., arg=<optimized out>) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:128
#4 0x00007fffa22e4a63 in QtPrivate::Functor<OutputWidget::outputFilter(const QString&)::<lambda()>, 0>::call<QtPrivate::List<>, void> (f=..., arg=<optimized out>) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:238
#5 0x00007fffa22e4a63 in QtPrivate::QFunctorSlotObject<OutputWidget::outputFilter(const QString&)::<lambda()>, 0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void **, bool *) (which=1, this_=<optimized out>, r=<optimized out>, a=<optimized out>, ret=<optimized out>)
at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:421
#6 0x00007ffff4ecbbef in QMetaObject::activate(QObject*, int, int, void**) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7 0x00007ffff4ecc24f in QObject::destroyed(QObject*) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8 0x00007ffff4ed2bca in QObject::~QObject() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9 0x00007ffff4e6b969 in QSortFilterProxyModel::~QSortFilterProxyModel() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x00007ffff4ec96ab in QObjectPrivate::deleteChildren() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#11 0x00007ffff4ed314b in QObject::~QObject() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#12 0x00007fffea8e5c79 in KDevelop::OutputModel::~OutputModel() (this=0x555557fe4c60, __in_chrg=<optimized out>)
at /home/htower/develop/kde_qt/kdevelop/kdevplatform/outputview/outputmodel.h:36
#13 0x00007ffff4ec96ab in QObjectPrivate::deleteChildren() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x00007ffff4ed314b in QObject::~QObject() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#15 0x00007fffa22eb9eb in OutputData::~OutputData() (this=0x55555800b640, __in_chrg=<optimized out>)
at /home/htower/develop/kde_qt/BUILD/kdevelop/plugins/standardoutputview/kdevstandardoutputview_autogen/EWIEGA46WW/../../../../../../kdevelop/plugins/standardoutputview/toolviewdata.h:38
#16 0x00007fffa22eb9eb in OutputData::~OutputData() (this=0x55555800b640, __in_chrg=<optimized out>)
at /home/htower/develop/kde_qt/BUILD/kdevelop/plugins/standardoutputview/kdevstandardoutputview_autogen/EWIEGA46WW/../../../../../../kdevelop/plugins/standardoutputview/toolviewdata.h:38
#17 0x00007ffff4ec96ab in QObjectPrivate::deleteChildren() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#18 0x00007ffff4ed314b in QObject::~QObject() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#19 0x00007fffa22ea849 in ToolViewData::~ToolViewData() (this=0x555557ff2a90, __in_chrg=<optimized out>)
at /home/htower/develop/kde_qt/kdevelop/plugins/standardoutputview/toolviewdata.cpp:65
#20 0x00007ffff4ec96ab in QObjectPrivate::deleteChildren() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#21 0x00007ffff4ed314b in QObject::~QObject() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#22 0x00007fffa22e1669 in StandardOutputView::~StandardOutputView() (this=0x555556226ad0, __in_chrg=<optimized out>)
at /home/htower/develop/kde_qt/kdevelop/plugins/standardoutputview/standardoutputview.cpp:94
#23 0x00007ffff7a99c2f in KDevelop::PluginController::unloadPlugin(KDevelop::IPlugin*, KDevelop::PluginController::PluginDeletion) (this=this@entry=0x555555edbf00, plugin=0x555556226ad0, deletion=deletion@entry=KDevelop::PluginController::Now)
at /home/htower/develop/kde_qt/kdevelop/kdevplatform/shell/plugincontroller.cpp:477
#24 0x00007ffff7a99df7 in KDevelop::PluginController::cleanup() (this=0x555555edbf00)
at /home/htower/develop/kde_qt/kdevelop/kdevplatform/shell/plugincontroller.cpp:358
#25 0x00007ffff7aaa83c in KDevelop::Core::cleanup() (this=this@entry=0x555555b3a050)
at /home/htower/develop/kde_qt/kdevelop/kdevplatform/shell/core.cpp:429
#26 0x00007ffff7aaab28 in KDevelop::Core::shutdown() (this=0x555555b3a050) at /home/htower/develop/kde_qt/kdevelop/kdevplatform/shell/core.cpp:385
#27 0x00007ffff7a8940d in KDevelop::MainWindow::~MainWindow() (this=this@entry=0x555555d1b480, __in_chrg=<optimized out>, __vtt_parm=<optimized out>)
at /home/htower/develop/kde_qt/kdevelop/kdevplatform/shell/mainwindow.cpp:159
#28 0x00007ffff7a89469 in KDevelop::MainWindow::~MainWindow() (this=0x555555d1b480, __in_chrg=<optimized out>, __vtt_parm=<optimized out>)
at /home/htower/develop/kde_qt/kdevelop/kdevplatform/shell/mainwindow.cpp:163
#29 0x00007ffff4ecc660 in QObject::event(QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#30 0x00007ffff5c69213 in QWidget::event(QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#31 0x00007ffff5d708d0 in QMainWindow::event(QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#32 0x00007ffff0dc5c77 in KMainWindow::event(QEvent*) () at /usr/lib/x86_64-linux-gnu/libKF5XmlGui.so.5
#33 0x00007ffff0e0abb5 in KXmlGuiWindow::event(QEvent*) () at /usr/lib/x86_64-linux-gnu/libKF5XmlGui.so.5
#34 0x00007ffff5c29e8c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#35 0x00007ffff5c3145f in QApplication::notify(QObject*, QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#36 0x00007ffff4e9cab8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#37 0x00007ffff4e9f5fd in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#38 0x00007ffff4ef7453 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#39 0x00007fffeb20d287 in g_main_context_dispatch () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#40 0x00007fffeb20d4c0 in () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#41 0x00007fffeb20d54c in g_main_context_iteration () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#42 0x00007ffff4ef6a7f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#43 0x00007fffcf6c7ed1 in () at /usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
#44 0x00007ffff4e9adea in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#45 0x00007ffff4ea3fa0 in QCoreApplication::exec() () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#46 0x00005555555601c0 in main(int, char**) (argc=<optimized out>, argv=<optimized out>) at /home/htower/develop/kde_qt/kdevelop/app/main.cpp:849</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15326">https://phabricator.kde.org/D15326</a></div></div><br /><div><strong>To: </strong>antonanikin, KDevelop<br /><strong>Cc: </strong>kossebau, vkorneev, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>