<table><tr><td style="">kossebau added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14931">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14931#inline-81585">View Inline</a><span style="color: #4b4d51; font-weight: bold;">anthonyfieroni</span> wrote in <span style="color: #4b4d51; font-weight: bold;">outputwidget.cpp:527</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">It's not correct, 3 line above you get a raw managed pointer, here you make a distinct managed pointer with same source. It'll result in double deletion when goes out of scope.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As <a href="https://phabricator.kde.org/p/anthonyfieroni/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@anthonyfieroni</a> said, there is a bug here:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">listview = m_views.begin().value().view.data();</pre></div>
<p style="padding: 0; margin: 8px;">takes a war copy of the pointer otherwise controlled by a QSharedPointer value.<br />
And <br />
<tt style="background: #ebebeb; font-size: 13px;"> </tt> `<br />
m_views[id].view = QSharedPointer<QTreeView>(listview);<br />
<tt style="background: #ebebeb; font-size: 13px;"> </tt> `<br />
then creates a new QSharedPointer around that raw pointer. As a result we have two sets of QSharedPointer for the very same pointer, which will result in double deletion once both sets go out of existance.</p>
<p style="padding: 0; margin: 8px;">Please fix this by making listview a QSharedPointer itself, so in case an existing pointer is taking, there will be only one set of QSharedPointer around that.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14931#inline-79527">View Inline</a><span style="color: #4b4d51; font-weight: bold;">outputwidget.cpp:260</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QTreeView<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n">view</span> <span style="color: #aa2211">=</span> <span class="n">m_views</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">id</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTreeView<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="n">view</span> <span style="color: #aa2211">=</span> <span class="n">m_views</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">id</span><span class="p">)<span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">view</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span><span class="p">(</span> <span class="n">data</span><span style="color: #aa2211">-></span><span class="n">type</span> <span style="color: #aa2211">&</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">IOutputView</span><span style="color: #aa2211">::</span><span class="n">MultipleView</span> <span style="color: #aa2211">||</span> <span class="n">data</span><span style="color: #aa2211">-></span><span class="n">type</span> <span style="color: #aa2211">&</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">IOutputView</span><span style="color: #aa2211">::</span><span class="n">HistoryView</span> <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">KDevelop coding style is to have the * with the type, so please keep that (<tt style="background: #ebebeb; font-size: 13px;">QTreeView*</tt>)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14931#inline-79526">View Inline</a><span style="color: #4b4d51; font-weight: bold;">outputwidget.h:110</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QMap</span><span style="color: #aa2211"><</span><span style="color: #aa4000">int</span><span class="p">,</span> <span class="n">FilteredView</span><span style="color: #aa2211">>::</span><span class="n">iterator</span> <span class="n">getFilteredView</span><span class="p">(</span><span class="n">QAbstractItemView</span> <span style="color: #aa2211">*</span><span class="n">view</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please remove the "get" prefix, name the method simply <tt style="background: #ebebeb; font-size: 13px;">filteredView(QAbstractItemView *view);</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14931">https://phabricator.kde.org/D14931</a></div></div><br /><div><strong>To: </strong>vkorneev, KDevelop, kfunk<br /><strong>Cc: </strong>kossebau, anthonyfieroni, aaronpuchert, kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>