<table><tr><td style="">arrowd added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14432">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14432#313275" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14432#313275</a>, <a href="https://phabricator.kde.org/p/kossebau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@kossebau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>IMHO we should change the code then to allow the respective vcs plugin used for the new project to write any additional data it wants/needs to store in the config, instead of this generic writing which is only currently needed for one system. No idea yet how this could be done, not looked at the code, just speaking in principle.</p></div>
</blockquote>
<p>Like this? <a href="https://bitbucket.org/arrowd/kdevelop-haskell/src/fe31614f904547ab3f9f36fd87a9915c52d9c6d9/haskellutils.cpp?at=master&fileviewer=file-view-default#haskellutils.cpp-87" class="remarkup-link" target="_blank" rel="noreferrer">https://bitbucket.org/arrowd/kdevelop-haskell/src/fe31614f904547ab3f9f36fd87a9915c52d9c6d9/haskellutils.cpp?at=master&fileviewer=file-view-default#haskellutils.cpp-87</a></p>
<p>There is more declarative approach to this using <tt style="background: #ebebeb; font-size: 13px;">.kcfg</tt> files: <a href="https://bitbucket.org/arrowd/kdevelop-haskell/src/fe31614f904547ab3f9f36fd87a9915c52d9c6d9/projectsettings.kcfg?at=master&fileviewer=file-view-default" class="remarkup-link" target="_blank" rel="noreferrer">https://bitbucket.org/arrowd/kdevelop-haskell/src/fe31614f904547ab3f9f36fd87a9915c52d9c6d9/projectsettings.kcfg?at=master&fileviewer=file-view-default</a><br />
which can be used like this: <a href="https://bitbucket.org/arrowd/kdevelop-haskell/src/fe31614f904547ab3f9f36fd87a9915c52d9c6d9/haskellsupport.cpp?at=master&fileviewer=file-view-default#haskellsupport.cpp-121" class="remarkup-link" target="_blank" rel="noreferrer">https://bitbucket.org/arrowd/kdevelop-haskell/src/fe31614f904547ab3f9f36fd87a9915c52d9c6d9/haskellsupport.cpp?at=master&fileviewer=file-view-default#haskellsupport.cpp-121</a></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14432#inline-79896">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appwizardplugin.cpp:406</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">developerProjectGroup</span><span class="p">.</span><span class="n">writeEntry</span><span class="p">(</span><span style="color: #766510">"VersionControlSupport"</span><span class="p">,</span> <span class="n">info</span><span class="p">.</span><span class="n">vcsPluginName</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">developerProjectGroup</span><span class="p">.</span><span class="n">writeEntry</span><span class="p">(</span><span style="color: #766510">"RepositoryServer"</span><span class="p">,</span> <span class="n">info</span><span class="p">.</span><span class="n">repository</span><span class="p">.</span><span class="n">repositoryServer</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">developerProjectGroup</span><span class="p">.</span><span class="n">writeEntry</span><span class="p">(</span><span style="color: #766510">"RepositoryUser"</span><span class="p">,</span> <span class="n">info</span><span class="p">.</span><span class="n">repository</span><span class="p">.</span><span class="n">userData</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not a request, just suggestion. How about renaming "Repository" to "VersionControl", so that these fields names are more aligned with each other.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14432">https://phabricator.kde.org/D14432</a></div></div><br /><div><strong>To: </strong>volden, KDevelop<br /><strong>Cc: </strong>arrowd, kossebau, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight<br /></div>