<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14958">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14958#inline-79931">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:13</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">if(WIN32</span>)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">    add_definitions( "-DP4_CLIENT_STUB_EXE=\"${CMAKE_CURRENT_BINARY_DIR}/../../../bin/p4clientstub.exe\"" </span>)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">else()
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    add_definitions( "-DP4_CLIENT_STUB_EXE=\"${CMAKE_CURRENT_BINARY_DIR}/../p4clientstub/p4clientstub\"" )
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">endif()
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright">add_definitions( "-DP4_BINARY_DIR=\"${PROJECT_BINARY_DIR}\""</span>)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright">add_definitions( "-DP4_CLIENT_STUB_EXE=\"p4clientstub${CMAKE_EXECUTABLE_SUFFIX}\""</span>)
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">With <a href="http://doc.qt.io/qt-5/qstandardpaths.html#findExecutable" class="remarkup-link" target="_blank" rel="noreferrer">http://doc.qt.io/qt-5/qstandardpaths.html#findExecutable</a> you wouldn't need to append <tt style="background: #ebebeb; font-size: 13px;">${CMAKE_EXECUTABLE_SUFFIX}</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14958#inline-79932">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_perforce.cpp:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">/// During test we are setting the executable the plugin uses to our own stub</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QDirIterator</span> <span style="color: #004012">it</span><span class="p">(</span><span class="n">P4_BINARY_DIR</span> <span class="p">,</span> <span class="n">QStringList</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span class="n">P4_CLIENT_STUB_EXE</span><span class="p">,</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">Files</span><span class="p">,</span> <span class="n">QDirIterator</span><span style="color: #aa2211">::</span><span class="n">Subdirectories</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">p4stubPath</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use <tt style="background: #ebebeb; font-size: 13px;">http://doc.qt.io/qt-5/qstandardpaths.html#findExecutable</tt>? Also <tt style="background: #ebebeb; font-size: 13px;">QVERIFY(...)</tt> that the executable was found maybe?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14958">https://phabricator.kde.org/D14958</a></div></div><br /><div><strong>To: </strong>volden, KDevelop, kfunk<br /><strong>Cc: </strong>kfunk, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>