<table><tr><td style="">Kebianizao added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14710">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14710#309769" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14710#309769</a>, <a href="https://phabricator.kde.org/p/brauch/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@brauch</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Thanks for the patch!</p>
<p>Sorry, it has been years since I looked at the debugger code. Why do you need to set the environment twice, once on the job and once on the process? Otherwise, this looks fine.</p></div>
</blockquote>
<p>As I review the code, I slowly remember what the "improved" version did. I think what it does is first storing the environment profile name in a DebugSession class member and then merging the default process environment with the profile environment variables in the DebugSession start function. If you have the patience I'll fix this differential following the initial approach and afterwards I'll consolidate the simplified environment handling approach in a new differential.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14710#inline-78951">View Inline</a><span style="color: #4b4d51; font-weight: bold;">brauch</span> wrote in <span style="color: #4b4d51; font-weight: bold;">debugsession.cpp:98</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">No, you are right, it's fine like you have it</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">OK.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14710#inline-78945">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Kebianizao</span> wrote in <span style="color: #4b4d51; font-weight: bold;">pdblauncher.cpp:134</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I well may wrong, but what I can tell is that:<br />
environment is a QMap<QString,QString><br />
when I do:<br />
for(const auto &i: environment), i type is QString so I should have to write this chunk as:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">for(const auto &i : environment)
{
job->m_environment << environment[i];
}</pre></div>
<p style="padding: 0; margin: 8px;">I don't know if this is what you were thinking.<br />
Now I got to this, maybe this is a good idea. I can submit the patch with this change if you like.<br />
Reference: <a href="https://stackoverflow.com/questions/8517853/iterating-over-a-qmap-with-for#8529237" class="remarkup-link" target="_blank" rel="noreferrer">https://stackoverflow.com/questions/8517853/iterating-over-a-qmap-with-for#8529237</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sorry I meant:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">for(const auto &i : environment)
{
job->m_environment << i + "=" + environment[i];
}</pre></div>
<p style="padding: 0; margin: 8px;">But anyway, I'll stick with what <a href="https://phabricator.kde.org/p/brauch/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@brauch</a> suggests.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R53 KDevelop: Python Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14710">https://phabricator.kde.org/D14710</a></div></div><br /><div><strong>To: </strong>Kebianizao, KDevelop<br /><strong>Cc: </strong>brauch, vkorneev, apol, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>