<table><tr><td style="">pino added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14288">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-76214">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:6</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> DESCRIPTION "Qt oriented code checker based on clang framework. Krazy's little brother"
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> URL "https://github.com/KDE/clazy"
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> PURPOSE "Recommended: required by the non-essential Clazy plugin"
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">github is not the primary location, which is git.kde.org.<br />
Please use: <a href="https://commits.kde.org/clazy" class="remarkup-link" target="_blank" rel="noreferrer">https://commits.kde.org/clazy</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-76215">View Inline</a><span style="color: #4b4d51; font-weight: bold;">checksdb.cpp:114</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">check</span><span style="color: #aa2211">-></span><span class="n">url</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"https://github.com/KDE/clazy/blob/master/docs/checks/README-%1.md"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">check</span><span style="color: #aa2211">-></span><span class="n">name</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">level</span><span style="color: #aa2211">-></span><span class="n">checks</span><span class="p">[</span><span class="n">check</span><span style="color: #aa2211">-></span><span class="n">name</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">check</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please do not make the plugin phone to github whenever an user wants to read the documentation of a check, it is also a privacy concern.<br />
It looks like clazy installs all the README-$check.md files, so please make use of the locally installed versions. It is also the best option, since you want to read the documentation of the check <em>you are using</em>, rather than the latest from the development branch.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-75965">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kossebau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">commandlinewidget.ui:13</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Unused property injected by Qt designer, please remove (also avoids string to appear for translators).</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">Unused property injected by Qt designer, please remove (also avoids string to appear for translators).</p></blockquote>
<p style="padding: 0; margin: 8px;">Run the <tt style="background: #ebebeb; font-size: 13px;">fixuifiles</tt> script that you can find in kde-dev-scripts (also available as kdesdk-scripts in some distros).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-75964">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kossebau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">globalconfigpage.ui:13</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Unused property injected by Qt designer, please remove (also avoids string to appear for translators).</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As said before, <tt style="background: #ebebeb; font-size: 13px;">fixuifiles</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-75963">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kossebau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">projectconfigpage.ui:13</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Unused property injected by Qt designer, please remove (also avoids string to appear for translators).</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As said before, <tt style="background: #ebebeb; font-size: 13px;">fixuifiles</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-76220">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevclazy.json:6</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Name"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"Anton Anikin"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Name[x-test]"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"xxAnton Anikinxx"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Any translation, including x-test, will be handled by l10n script -- hence, do not add it manually.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-76219">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevclazy.json:11</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Description"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"This plugin integrates Clazy to KDevelop"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Description[x-test]"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"xxThis plugin integrates Clazy to KDevelopxx"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Icon"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"kdevelop"</span><span style="color: #aa2211">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ditto.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-76221">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevclazy.json:16</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Name"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"Clazy Support"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Name[x-test]"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"xxClazy Supportxx"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"ServiceTypes"</span><span style="color: #aa2211">:</span> <span style="color: #aa2211">[</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ditto.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-76222">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plugin.cpp:185-187</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">errorMessage</span> <span style="color: #aa2211">+=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unable to start clazy check for </span><span style="color: #bb6622">\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"</span><span style="color: #766510">:"</span><span class="p">,</span> <span class="n">path</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">errorMessage</span> <span style="color: #aa2211">+=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\n\n</span><span style="color: #766510">"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">errorMessage</span> <span style="color: #aa2211">+=</span> <span class="n">params</span><span class="p">.</span><span class="n">error</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is a string puzzle that can be avoided, since you have the whole message at this point:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">errorMessage</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unable to start clazy check for </span><span style="color: #bb6622">\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"</span><span style="color: #766510">:</span><span style="color: #bb6622">\n\n</span><span style="color: #766510">%2"</span><span class="p">,</span> <span class="n">path</span><span class="p">,</span> <span class="n">params</span><span class="p">.</span><span class="n">error</span><span class="p">());</span></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-76224">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemmodel.cpp:111-114</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">tooltip</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@info:tooltip"</span><span class="p">,</span> <span style="color: #766510">"Re-Run Last Clazy Analysis"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_project</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">tooltip</span> <span style="color: #aa2211">+=</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">" (%1)"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">prettyPathName</span><span class="p">(</span><span class="n">m_path</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">String puzzle -- just use two strings:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">QString</span> <span class="n">tooltip</span><span class="p">;</span>
<span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_project</span><span class="p">)</span> <span class="p">{</span>
<span class="n">tooltip</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@info:tooltip %1 is the path of the file"</span><span class="p">,</span> <span style="color: #766510">"Re-run last Clazy analysis (%1)"</span><span class="p">,</span> <span class="n">prettyPathName</span><span class="p">(</span><span class="n">m_path</span><span class="p">));</span>
<span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
<span class="n">tooltip</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@info:tooltip"</span><span class="p">,</span> <span style="color: #766510">"Re-run last Clazy analysis"</span><span class="p">);</span>
<span class="p">}</span></pre></div>
<p style="padding: 0; margin: 8px;">Also tooltips do not get title capitalization.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14288#inline-76225">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_clazyjob.cpp:82</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">TestClazyJob</span><span style="color: #aa2211">::</span><span class="n">initTestCase</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Here, make sure to <tt style="background: #ebebeb; font-size: 13px;">QSKIP</tt> the whole test if clazy is not installed.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14288">https://phabricator.kde.org/D14288</a></div></div><br /><div><strong>To: </strong>antonanikin, KDevelop<br /><strong>Cc: </strong>pino, kossebau, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>