<table><tr><td style="">croick created this revision.<br />croick added a reviewer: KDevelop.<br />Restricted Application added a subscriber: kdevelop-devel.<br />croick requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12527">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Deleting the document directly may lead to calling the destructor again from the event handler during destruction (see <a href="https://phabricator.kde.org/D12131" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12131</a>).</li>
<li class="remarkup-list-item">revert already attempted in <a href="https://phabricator.kde.org/R33:72e2bea870d6762ba34923cef5b0b80388ff5326" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">72e2bea870d6</a>, but never merged</li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">PartDocument::close</tt> calls deleteLater on documents, so overriding the function is superfluous</li>
<li class="remarkup-list-item">The initial purpose (of fixing event handler issues) seems to be fulfilled already.</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">close KDevelop with a displayed kmarkdownwebview plugin</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>textdocdelete</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12527">https://phabricator.kde.org/D12527</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kdevplatform/shell/textdocument.cpp<br />
kdevplatform/shell/textdocument.h</div></div></div><br /><div><strong>To: </strong>croick, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>