<table><tr><td style="">mwolff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12220">View Revision</a></tr></table><br /><div><div><p>I'm very unsure about this. On one hand, this obviously looks better in your screenshots. On the other hand, what if we encounter comments that are formatted with some other syntax? Most notably consider how your code would lead to broken HTML quite easily, e.g. when only part of a match is encountered (such as only <tt style="background: #ebebeb; font-size: 13px;">\f\[</tt> but no <tt style="background: #ebebeb; font-size: 13px;">\f\]</tt>).</p>
<p>Furthermore, you are introducing untranslatable strings that may be odd when rendered (e.g. when the comment is actually German or such). If at all, then I would say we should keep the doxygen strings and just apply formatting, but not change any string conents. So <tt style="background: #ebebeb; font-size: 13px;">@see</tt> will be rendered as <strong><span class="phabricator-remarkup-mention-unknown">@see</span></strong>, instead of <strong>See also:</strong></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12220#inline-61817">View Inline</a><span style="color: #4b4d51; font-weight: bold;">abstractdeclarationnavigationcontext.cpp:792</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span><span class="p">(</span> <span class="n">QString</span> <span style="color: #a0a000">line</span> <span class="p">:</span> <span class="n">comment</span><span class="p">.</span><span class="n">split</span><span class="p">(</span><span style="color: #766510">'\n'</span><span class="p">)</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">line</span> <span style="color: #aa2211">=</span> <span class="n">line</span><span class="p">.</span><span class="n">trimmed</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">for (auto lineRef : comment.splitRef(QLatin1Char('\n')) {
QString line = lineRef.trimmed();
...
}</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12220#inline-61816">View Inline</a><span style="color: #4b4d51; font-weight: bold;">abstractdeclarationnavigationcontext.cpp:795</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">line</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="n">QRegExp</span><span class="p">(</span><span style="color: #766510">"^(@param|</span><span style="color: #bb6622">\\\\</span><span style="color: #766510">param)</span><span style="color: #bb6622">\\</span><span style="color: #766510">[(in|out|in,out)</span><span style="color: #bb6622">\\</span><span style="color: #766510">] ([</span><span style="color: #bb6622">\\</span><span style="color: #766510">w]+) (.*)"</span><span class="p">),</span> <span style="color: #766510">"</span><span style="color: #bb6622">\\</span><span style="color: #766510">2 <strong></span><span style="color: #bb6622">\\</span><span style="color: #766510">3</strong>: <em></span><span style="color: #bb6622">\\</span><span style="color: #766510">4</em>"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please don't use QRegExp in new code, use QRegularExpression instead</p>
<p style="padding: 0; margin: 8px;">also, wrap all string literals in QStringLiteral</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12220">https://phabricator.kde.org/D12220</a></div></div><br /><div><strong>To: </strong>progwolff, KDevelop<br /><strong>Cc: </strong>mwolff, croick, kdevelop-devel<br /></div>