<table><tr><td style="">kfunk created this revision.<br />Restricted Application added a subscriber: kdevelop-devel.<br />kfunk requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11601">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Call the KTextEditor::View methods for reading & storing the state:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">KTextEditor::View::readSessionConfig()</li>
<li class="remarkup-list-item">KTextEditor::View::writeSessionConfig()</li>
</ul>
<p>Remove our implementation of storing the state of ...:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Cursor</li>
<li class="remarkup-list-item">Selection</li>
</ul>
<p>By using the KTextEditor methods we do save the states of ...:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Cursor</li>
<li class="remarkup-list-item">Dynamic Word Wrap</li>
<li class="remarkup-list-item">Text Folding nodes</li>
<li class="remarkup-list-item">...</li>
</ul>
<p>Thus, with this patch the storing & retrieving of the selection state is<br />
lost. To be honest, I don't see that as a super useful feature anyway.</p>
<p>FIXED-IN: 5.3.0<br />
BUG: 385919</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11601">https://phabricator.kde.org/D11601</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kdevplatform/shell/textdocument.cpp<br />
kdevplatform/shell/textdocument.h<br />
kdevplatform/shell/workingsets/workingset.cpp<br />
kdevplatform/sublime/view.cpp<br />
kdevplatform/sublime/view.h</div></div></div><br /><div><strong>To: </strong>kfunk<br /><strong>Cc: </strong>kdevelop-devel<br /></div>