<table><tr><td style="">huguesmorisset updated this revision to Diff 25999.<br />huguesmorisset retitled this revision from "Change call to openDeclaration to send an Identifier instead of an QualifiedIdentifier" to "Fix compiler warnings".<br />huguesmorisset edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-ewytfg2h2kqkvke/" rel="noreferrer">(Show Details)</a>
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10115" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">- Fix unused parameters warnings<br />
- Change call to openDeclaration to send an Identifier instead of an QualifiedIdentifier <br />
</span>What the deprecated method does:<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span>```<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span> auto openDeclaration(QualifiedIdentifier x, ...) {<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span> Identifier i;<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span> if (!x.isEmpty()) {<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span> i = x.last();<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span> }<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span> return openDeclaration(i, ...);<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span> }<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span>```<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> <br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
</span>This does remove a check to isEmpty().</div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R59 KDevelop Go</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D10115?vs=25996&id=25999" rel="noreferrer">https://phabricator.kde.org/D10115?vs=25996&id=25999</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10115" rel="noreferrer">https://phabricator.kde.org/D10115</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>codecompletion/context.cpp<br />
codecompletion/items/completionitem.cpp<br />
codecompletion/worker.cpp<br />
duchain/builders/contextbuilder.cpp<br />
duchain/builders/declarationbuilder.cpp<br />
duchain/builders/typebuilder.cpp<br />
duchain/expressionvisitor.cpp<br />
duchain/helper.cpp<br />
golangparsejob.cpp<br />
parser/parsesession.cpp<br />
parser/parsesession.h</div></div></div><br /><div><strong>To: </strong>huguesmorisset<br /><strong>Cc: </strong>kdevelop-devel<br /></div>