<table><tr><td style="">croick created this revision.<br />croick added a reviewer: KDevelop.<br />Restricted Application added a subscriber: kdevelop-devel.<br />croick requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9956" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">fetching the history of an svn project only worked sometimes</li>
<li class="remarkup-list-item">trying to show a diff between versions lead to a crash</li>
<li class="remarkup-list-item">displaying a diff from the annotation border lead to a crash</li>
</ul>

<ul class="remarkup-list">
<li class="remarkup-list-item">remove UI files which are not used</li>
<li class="remarkup-list-item">remove unused svncatjob and svncheckoutmetadatawidget</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">display history/log from vcs context menu entry</li>
<li class="remarkup-list-item">display diff from history list</li>
<li class="remarkup-list-item">display diff from annotation border</li>
<li class="remarkup-list-item">fetch svn project using the assistant</li>
<li class="remarkup-list-item">commit changes of an svn project</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>svnlog</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9956" rel="noreferrer">https://phabricator.kde.org/D9956</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/subversion/CMakeLists.txt<br />
plugins/subversion/kdevsvnplugin.cpp<br />
plugins/subversion/kdevsvnplugin.h<br />
plugins/subversion/svncatjob.cpp<br />
plugins/subversion/svncatjob.h<br />
plugins/subversion/svncatjob_p.h<br />
plugins/subversion/svncheckoutmetadatawidget.cpp<br />
plugins/subversion/svncheckoutmetadatawidget.h<br />
plugins/subversion/svndiffjob.cpp<br />
plugins/subversion/svninternaljobbase.cpp<br />
plugins/subversion/svnjobbase.cpp<br />
plugins/subversion/svnlogjob.cpp<br />
plugins/subversion/ui/blameoptiondlg.ui<br />
plugins/subversion/ui/catoptiondlg.ui<br />
plugins/subversion/ui/checkoutmetadatawidget.ui<br />
plugins/subversion/ui/commitloginputdlg.ui<br />
plugins/subversion/ui/copyoptiondlg.ui<br />
plugins/subversion/ui/diffoptiondlg.ui<br />
plugins/subversion/ui/logviewoptiondlg.ui<br />
plugins/subversion/ui/moveoptiondlg.ui<br />
plugins/subversion/ui/revertoptiondlg.ui<br />
plugins/subversion/ui/revisionwidget.ui<br />
plugins/subversion/ui/statusoptiondlg.ui<br />
plugins/subversion/ui/updateoptiondlg.ui</div></div></div><br /><div><strong>To: </strong>croick, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>