<table><tr><td style="">dweatherill updated this revision to Diff 25164.<br />dweatherill added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9809" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>as per review, this updated diff uses QSignalBlocker instead of blockSignals()</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D9809?vs=25134&id=25164" rel="noreferrer">https://phabricator.kde.org/D9809?vs=25134&id=25164</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9809" rel="noreferrer">https://phabricator.kde.org/D9809</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp<br />
plugins/custom-definesandincludes/compilerprovider/widget/compilerswidget.cpp</div></div></div><br /><div><strong>To: </strong>dweatherill, KDevelop, apol<br /><strong>Cc: </strong>mwolff, anthonyfieroni, kdevelop-devel, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>