<table><tr><td style="">aaronpuchert added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8634" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8634#163888" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8634#163888</a>, <a href="https://phabricator.kde.org/p/mwolff/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mwolff</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I figured - couldn't we simply replace <tt style="background: #ebebeb; font-size: 13px;">ParserArguments</tt> with e.g. a <tt style="background: #ebebeb; font-size: 13px;">QHash<Utils::LanguageType, QString></tt>? Or, better yet, we make it a <tt style="background: #ebebeb; font-size: 13px;">QString[Utils::LanguageType::Other]</tt>?</p></div>
</blockquote>
<p>There is still that flag <tt style="background: #ebebeb; font-size: 13px;">parseAmbiguousAsCPP</tt>, but I like the idea of using an array. Maybe we can get rid of the flag, but I wouldn't want to do too much in one change.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>you'd still be able to use brace-initialization</p></blockquote>
<p>As stated in the commit message, I don't think a bare-bones initializer list of strings is very readable, because it's not clear which arguments belong to which language when reading it. However, I don't see any issue with an initializer list consisting of <tt style="background: #ebebeb; font-size: 13px;">std::pair<Utils::LanguageType, QString></tt>, if you like that.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8634#inline-37830" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mwolff</span> wrote in <span style="color: #4b4d51; font-weight: bold;">settingsmanager.cpp:59</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">rename to <tt style="background: #ebebeb; font-size: 13px;">configKey</tt> or such?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's already used in line 45. I could name it <tt style="background: #ebebeb; font-size: 13px;">parserArgumentsKey</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8634#inline-37824" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mwolff</span> wrote in <span style="color: #4b4d51; font-weight: bold;">settingsmanager.cpp:79</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">move this down, such that the anon namespace includes all util functions, esp. the ones you are touching.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This closes the <tt style="background: #ebebeb; font-size: 13px;">ConfigConstants</tt> namespace, so I guess I'm going to leave it there.</p>
<p style="padding: 0; margin: 8px;">The anonymous namespace is closed on line 266.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8634" rel="noreferrer">https://phabricator.kde.org/D8634</a></div></div><br /><div><strong>To: </strong>aaronpuchert, KDevelop, apol<br /><strong>Cc: </strong>apol, mwolff, kdevelop-devel<br /></div>