<table><tr><td style="">aaronpuchert added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8654" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Technically, we need only <a href="https://phabricator.kde.org/D8653" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" rel="noreferrer">D8653</a> or this change to fix <a href="https://bugs.kde.org/show_bug.cgi?id=386388" class="remarkup-link" target="_blank" rel="noreferrer">bug 386388</a>. Do we still want this change?</p>

<p>The changes in the <tt style="background: #ebebeb; font-size: 13px;">DefinesAndIncludesManager</tt> make things certainly more consistent.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>qmljs-fix</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8654" rel="noreferrer">https://phabricator.kde.org/D8654</a></div></div><br /><div><strong>To: </strong>aaronpuchert, KDevelop, mwolff<br /><strong>Cc: </strong>mwolff, kdevelop-devel<br /></div>