<table><tr><td style="">kossebau updated this revision to Diff 21695.<br />kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8588" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>simplify unit tests a little by testing detaching only by one property</p>

<p>After all we know details of the implementation, and as we test specifically<br />
for the detach situation where we know it should be the same for any<br />
non-const method, doing just one setter and then testing the values of all<br />
properties in both copies should cover the most potential errors.</p>

<p>-> less code, more coverage of critical behaviour</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D8588?vs=21681&id=21695" rel="noreferrer">https://phabricator.kde.org/D8588?vs=21681&id=21695</a></div></div><br /><div><strong>BRANCH</strong><div><div>makedataobjectimplicitelyshared</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8588" rel="noreferrer">https://phabricator.kde.org/D8588</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kdevplatform/vcs/CMakeLists.txt<br />
kdevplatform/vcs/tests/CMakeLists.txt<br />
kdevplatform/vcs/tests/test_vcsannotation.cpp<br />
kdevplatform/vcs/tests/test_vcsannotation.h<br />
kdevplatform/vcs/tests/test_vcsannotationline.cpp<br />
kdevplatform/vcs/tests/test_vcsannotationline.h<br />
kdevplatform/vcs/tests/test_vcsdiff.cpp<br />
kdevplatform/vcs/tests/test_vcsdiff.h<br />
kdevplatform/vcs/tests/test_vcsevent.cpp<br />
kdevplatform/vcs/tests/test_vcsevent.h<br />
kdevplatform/vcs/tests/test_vcsitemevent.cpp<br />
kdevplatform/vcs/tests/test_vcsitemevent.h<br />
kdevplatform/vcs/tests/test_vcsrevision.cpp<br />
kdevplatform/vcs/tests/test_vcsrevision.h<br />
kdevplatform/vcs/tests/test_vcsstatusinfo.cpp<br />
kdevplatform/vcs/tests/test_vcsstatusinfo.h<br />
kdevplatform/vcs/vcsannotation.cpp<br />
kdevplatform/vcs/vcsannotation.h<br />
kdevplatform/vcs/vcsdiff.cpp<br />
kdevplatform/vcs/vcsdiff.h<br />
kdevplatform/vcs/vcsevent.cpp<br />
kdevplatform/vcs/vcsevent.h<br />
kdevplatform/vcs/vcsrevision.cpp<br />
kdevplatform/vcs/vcsrevision.h<br />
kdevplatform/vcs/vcsstatusinfo.cpp<br />
kdevplatform/vcs/vcsstatusinfo.h</div></div></div><br /><div><strong>To: </strong>kossebau, KDevelop<br /><strong>Cc: </strong>brauch, kdevelop-devel<br /></div>