<table><tr><td style="">kossebau created this revision.<br />kossebau added a reviewer: KDevelop.<br />Restricted Application added a subscriber: kdevelop-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8588" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Also</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">rely on default implementation of copy constructor to copy all data on forking the internal data objects</li>
<li class="remarkup-list-item">mark as movable types for improved handling in Qt containers</li>
</ul>

<p>Object of these classes are created in one place and then passed around<br />
for read-only consumption. They are passed by value in method return<br />
arguments and stored by value. As the classes already have a private<br />
object for pimpl, making this an implicitly shared one is a small step.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>makedataobjectimplicitelyshared</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8588" rel="noreferrer">https://phabricator.kde.org/D8588</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kdevplatform/vcs/CMakeLists.txt<br />
kdevplatform/vcs/tests/CMakeLists.txt<br />
kdevplatform/vcs/tests/test_vcsannotation.cpp<br />
kdevplatform/vcs/tests/test_vcsannotation.h<br />
kdevplatform/vcs/tests/test_vcsannotationline.cpp<br />
kdevplatform/vcs/tests/test_vcsannotationline.h<br />
kdevplatform/vcs/tests/test_vcsdiff.cpp<br />
kdevplatform/vcs/tests/test_vcsdiff.h<br />
kdevplatform/vcs/tests/test_vcsevent.cpp<br />
kdevplatform/vcs/tests/test_vcsevent.h<br />
kdevplatform/vcs/tests/test_vcsitemevent.cpp<br />
kdevplatform/vcs/tests/test_vcsitemevent.h<br />
kdevplatform/vcs/tests/test_vcsrevision.cpp<br />
kdevplatform/vcs/tests/test_vcsrevision.h<br />
kdevplatform/vcs/tests/test_vcsstatusinfo.cpp<br />
kdevplatform/vcs/tests/test_vcsstatusinfo.h<br />
kdevplatform/vcs/vcsannotation.cpp<br />
kdevplatform/vcs/vcsannotation.h<br />
kdevplatform/vcs/vcsdiff.cpp<br />
kdevplatform/vcs/vcsdiff.h<br />
kdevplatform/vcs/vcsevent.cpp<br />
kdevplatform/vcs/vcsevent.h<br />
kdevplatform/vcs/vcsrevision.cpp<br />
kdevplatform/vcs/vcsrevision.h<br />
kdevplatform/vcs/vcsstatusinfo.cpp<br />
kdevplatform/vcs/vcsstatusinfo.h</div></div></div><br /><div><strong>To: </strong>kossebau, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>