<table><tr><td style="">kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8158" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8158#152647" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8158#152647</a>, <a href="https://phabricator.kde.org/p/rjvbb/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@rjvbb</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Does drkonqui still automatically select the right version in Bugzilla if we do this ...? (It does that, right?)</p></blockquote>
<p>I haven't gone so far as to submit an actual bug report. I'd hope that some kind of pattern matching is done, either in DrKonqi or by the Bugzilla software itself. Which btw. only seems to know release versions.</p></div>
</blockquote>
<p>Please don't hope -- test it. If the problem is a non-existing release version, fake a released version for testing.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Looking at it, no, you definitely cannot do it like this. You overwrite KDevelop_VERSION_PATCH, which is e.g. exported to kdevelop-config.cmake and will require e.g. kdev-php to depend on "kdevelop VERSION 5.1.80-24-g5623457794"...</p></blockquote>
<p>I wasn't sure about that because I can find no evidence that this version is exported in a headerfile or .cmake file. What did I overlook?<br />
Is it safer to rewrite just the full version string (and would it be acceptable/safe to include the 'v' in there - if not it can be removed in software)?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also, you run this at build generation time, so if you do a change + commit which don't cause cmake to re-generate the build system, the version number won't change.</p>
<p>Also, as said, this will just cause the build to fail on Windows.</p></blockquote>
<p>How many bug reports do you get that are generated automatically on MS Windows (via DrKonqi or the built-in bug reporter)?</p></blockquote>
<p>There's no DrKonqi on Windows. But people are using the bug reporter. Not that it matters in this discussion though. We'd like to have cross-platform solutions.</p>
<p>But that point is now moot anyway, now that you use that CMake module.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I see 2 options, presuming that the feature is deemed of interest:<br />
1 exclude MS Windows, which would make it possible (or simpler) to write something that always updates the full version string<br />
2 don't a helper script, execute git directly from the CMake file to rewrite just a full version string used by KAboutData, and do the required post-processing in main.cpp</p>
<p>With option 2) it would be the developer's responsibility to take care of regenerating the version string, for instance by removing $build.dir/kdevelop-config.h in post-commit and post-fetch hooks. We could even provide instructions for that.</p></blockquote>
</div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8158#inline-34200" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:378</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">aboutData</span><span class="p">.</span><span class="n">addCredit</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Matt Rogers"</span><span class="p">),</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"mattr@kde.org"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">aboutData</span><span class="p">.</span><span class="n">addCredit</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"C<span class="bright">é</span>dric Pasteur"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"astyle and indent support"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"cedric.pasteur@free.fr"</span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">aboutData</span><span class="p">.</span><span class="n">addCredit</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"C<span class="bright">�</span>dric Pasteur"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"astyle and indent support"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"cedric.pasteur@free.fr"</span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">aboutData</span><span class="p">.</span><span class="n">addCredit</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Evgeniy Ivanov"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Distributed VCS, Git, Mercurial"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"powerfox@kde.ru"</span><span class="p">)</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unintended change.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8158" rel="noreferrer">https://phabricator.kde.org/D8158</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop, brauch, kfunk<br /><strong>Cc: </strong>kossebau, flherne, mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>