<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8158" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>+1 for the option to note the git version somethere<br />
-1 for the approach in the patch.</p>
<p>For getting the git version, you could have a look at the approach done e.g. in calligra or krita,have a look at:<br />
<a href="https://cgit.kde.org/calligra.git/tree/CMakeLists.txt" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/calligra.git/tree/CMakeLists.txt</a><br />
<a href="https://cgit.kde.org/calligra.git/tree/cmake/modules/GetGitRevisionDescription.cmake" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/calligra.git/tree/cmake/modules/GetGitRevisionDescription.cmake</a></p>
<p>I would propose to put the very git version only in the UI aboutdata strings and also only for development builds (which opens the question how to define whether it is a development build).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8158" rel="noreferrer">https://phabricator.kde.org/D8158</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop, brauch<br /><strong>Cc: </strong>kossebau, flherne, mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>