<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7950" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7950#148564" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D7950#148564</a>, <a href="https://phabricator.kde.org/p/rjvbb/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@rjvbb</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Make that <tt style="background: #ebebeb; font-size: 13px;">-DCMAKE_DISABLE_FIND_PACKAGE_Qt5WebEngineWidgets=ON</tt> but then it works. I see now that the <tt style="background: #ebebeb; font-size: 13px;">REQUIRED</tt> nature is not declared in the find_package command but in <tt style="background: #ebebeb; font-size: 13px;">set_package_properties</tt>, I guess that's why it works?</p></div>
</blockquote>

<p>Yes. If it would be <tt style="background: #ebebeb; font-size: 13px;">REQUIRED</tt> in <tt style="background: #ebebeb; font-size: 13px;">find_package</tt>, it would fail. Took me 3 seconds to verify:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ cmake -DCMAKE_DISABLE_FIND_PACKAGE_Qt5Core=ON .</span>
<span style="color: #808080"></span>
<span style="color: #808080">CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Qt5/Qt5Config.cmake:26 (find_package):</span>
<span style="color: #808080">  find_package for module Qt5Core called with REQUIRED, but</span>
<span style="color: #808080">  CMAKE_DISABLE_FIND_PACKAGE_Qt5Core is enabled.  A REQUIRED package cannot</span>
<span style="color: #808080">  be disabled.</span></pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7950" rel="noreferrer">https://phabricator.kde.org/D7950</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop, apol, kfunk<br /><strong>Cc: </strong>kfunk, apol, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>