<table><tr><td style="">mwolff requested changes to this revision.<br />mwolff added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7799" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>overall lgtm, I'd also like to see some unit test coverage please</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7799#inline-32152" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">builder.cpp:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">// TODO: investigate upstream implementation of CXCursor_TypeAliasTemplateDecl</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">CXCursor</span> <span class="n">getEmbeddedTypeAlias</span><span class="p">(</span><span class="n">CXCursor</span> <span class="n">aliasTemplate</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please remove the <tt style="background: #ebebeb; font-size: 13px;">get</tt> prefix. Just call it <tt style="background: #ebebeb; font-size: 13px;">embeddedTypeAlias</tt> or use a <tt style="background: #ebebeb; font-size: 13px;">find</tt> prefix</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7799#inline-32153" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">builder.cpp:78</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">CXCursor</span> <span class="n">result</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">clang_visitChildren</span><span class="p">(</span><span class="n">aliasTemplate</span><span class="p">,</span> <span class="p">[]</span> <span class="p">(</span><span class="n">CXCursor</span> <span class="n">cursor</span><span class="p">,</span> <span class="n">CXCursor</span><span class="p">,</span> <span class="n">CXClientData</span> <span class="n">data</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just to ensure it's properly initialized, I'd write:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">auto result = clang_getNullCursor();</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7799#inline-32154" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">builder.cpp:80</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">clang_visitChildren</span><span class="p">(</span><span class="n">aliasTemplate</span><span class="p">,</span> <span class="p">[]</span> <span class="p">(</span><span class="n">CXCursor</span> <span class="n">cursor</span><span class="p">,</span> <span class="n">CXCursor</span><span class="p">,</span> <span class="n">CXClientData</span> <span class="n">data</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">auto</span> <span class="n">res</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">reinterpret_cast</span><span style="color: #aa2211"><</span><span class="n">CXCursor</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">data</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">clang_getCursorKind</span><span class="p">(</span><span class="n">cursor</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span class="n">CXCursor_TypeAliasDecl</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">move this into the if branch below, it's only used there</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7799" rel="noreferrer">https://phabricator.kde.org/D7799</a></div></div><br /><div><strong>To: </strong>craigt, KDevelop, mwolff, kfunk<br /><strong>Cc: </strong>apol, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>