<table><tr><td style="">apol updated this revision to Diff 19464.<br />apol marked 2 inline comments as done.<br />apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7752" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Addressed Milian's comments</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D7752?vs=19346&id=19464" rel="noreferrer">https://phabricator.kde.org/D7752?vs=19346&id=19464</a></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7752" rel="noreferrer">https://phabricator.kde.org/D7752</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kdevplatform/project/interfaces/ibuildsystemmanager.h<br />
languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp<br />
projectmanagers/cmake/cmakemanager.cpp<br />
projectmanagers/cmake/cmakemanager.h<br />
projectmanagers/cmake/cmakeprojectdata.h<br />
projectmanagers/cmake/cmakeserverimportjob.cpp<br />
projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp<br />
projectmanagers/custom-buildsystem/custombuildsystemplugin.h<br />
projectmanagers/custommake/custommakemanager.cpp<br />
projectmanagers/custommake/custommakemanager.h<br />
projectmanagers/qmake/qmakemanager.cpp<br />
projectmanagers/qmake/qmakemanager.h<br />
projectmanagers/qmake/qmakeprojectfile.cpp<br />
projectmanagers/qmake/qmakeprojectfile.h</div></div></div><br /><div><strong>To: </strong>apol, KDevelop, kfunk, mwolff<br /><strong>Cc: </strong>mwolff, kdevelop-devel<br /></div>