<table><tr><td style="">mwolff requested changes to this revision.<br />mwolff added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7752" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32091" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cmakemanager.cpp:289</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QString</span> <span class="n">CMakeManager</span><span style="color: #aa2211">::</span><span class="n">extraArguments</span><span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span><span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">)</span> <span style="color: #aa4000">const</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">move <tt style="background: #ebebeb; font-size: 13px;">*</tt> next to item, like above(?)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32090" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cmakemanager.h:87</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">QString</span><span style="color: #aa2211">></span> <span class="n">defines</span><span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span> <span style="color: #aa2211">*</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">override</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span style="color: #004012">extraArguments</span><span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span> <span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">override</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">remove space after <tt style="background: #ebebeb; font-size: 13px;">*</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32092" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">custombuildsystemplugin.h:79</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">Path</span><span style="color: #aa2211">::</span><span class="n">List</span> <span class="n">frameworkDirectories</span><span class="p">(</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span><span style="color: #aa2211">*</span> <span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">override</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span style="color: #004012">extraArguments</span><span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span> <span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">override</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">bool</span> <span style="color: #004012">removeFilesFromTargets</span><span class="p">(</span> <span style="color: #aa4000">const</span> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectFileItem</span><span style="color: #aa2211">*>&</span> <span class="p">)</span> <span class="n">override</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">dito space</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32093" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">custommakemanager.h:59</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span style="color: #004012">extraArguments</span><span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span> <span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">override</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">dito</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32094" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmakemanager.h:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span><span class="n">QString</span><span style="color: #aa2211">></span> <span class="n">defines</span><span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span><span style="color: #aa2211">*</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">override</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span style="color: #004012">extraArguments</span><span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span> <span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">override</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">bool</span> <span style="color: #004012">hasBuildInfo</span><span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span><span style="color: #aa2211">*</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">override</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">dito</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32097" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmakeprojectfile.cpp:292</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">variablesToCheck</span> <span style="color: #aa2211">=</span> <span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"QMAKE_CFLAGS"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"QMAKE_CXXFLAGS"</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">imo it should be either CFLAGS or CXXFLAGS, not a combination of the two which could lead really funky combinations that would break in magic ways... Could you maybe check at the callee site whether we are interested in C or C++ flags?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32096" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmakeprojectfile.cpp:294</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"QMAKE_CXXFLAGS"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"QMAKE_LFLAGS"</span><span class="p">)};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">QLatin1String</span><span style="color: #aa2211">></span> <span class="n">prefixes</span> <span style="color: #aa2211">=</span> <span class="p">{</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"-F"</span><span class="p">),</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"-iframework"</span><span class="p">),</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"-I"</span><span class="p">)</span> <span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why LFLAGS, that sounds unnecessary for our purposes</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32095" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmakeprojectfile.cpp:295</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"QMAKE_LFLAGS"</span><span class="p">)};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">QLatin1String</span><span style="color: #aa2211">></span> <span class="n">prefixes</span> <span style="color: #aa2211">=</span> <span class="p">{</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"-F"</span><span class="p">),</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"-iframework"</span><span class="p">),</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"-I"</span><span class="p">)</span> <span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringList</span> <span class="n">args</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">-isystem</tt> too? And is it really "-F" or did you mean "-D"?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7752#inline-32098" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmakeprojectfile.cpp:300</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span><span style="color: #aa2211">&</span> <span style="color: #a0a000">prefix</span><span class="p">:</span> <span class="n">prefixes</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">arg</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span class="n">prefix</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">args</span> <span style="color: #aa2211"><<</span> <span class="n">arg</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this should be negated, no? You want to find everything that is _not_ an include path, no? Also, defines should be skipped too, thus <tt style="background: #ebebeb; font-size: 13px;">-D</tt> above, not <tt style="background: #ebebeb; font-size: 13px;">-F</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7752" rel="noreferrer">https://phabricator.kde.org/D7752</a></div></div><br /><div><strong>To: </strong>apol, KDevelop, kfunk, mwolff<br /><strong>Cc: </strong>mwolff, kdevelop-devel<br /></div>