<table><tr><td style="">akellermann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7040" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>The regex change is no problem, but I need some hints concerning unit tests.</p>

<p>First of all, there are two tests that seem to cover filtering strategies:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">./kdevelop/kdevplatform/outputview/tests/test_filteringstrategy.cpp</tt></li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">./kdevplatform/outputview/tests/test_filteringstrategy.cpp</tt>.</li>
</ol>

<p>In both files I added something like:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QTest::newRowForPathType("cmake-cd-line8", pathType)
<< QString("> /usr/bin/cmake -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_BUILD_TYPE=Debug " + basepath)
<< QString( basepath )
<< pathType;</pre></div>

<p>to <tt style="background: #ebebeb; font-size: 13px;">void TestFilteringStrategy::testCompilerFilterstrategyUrlFromAction_data()</tt>, but it's not working.<br />
In one case my changes seem to be ignored, in the other case I get a fatal error (at <tt style="background: #ebebeb; font-size: 13px;">/home/axel/Projects/kdesrc/kdevelop/kdevplatform/outputview/tests/test_filteringstrategy.cpp:418</tt>).</p>

<p>What am I missing? Any help would be appreciated.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7040" rel="noreferrer">https://phabricator.kde.org/D7040</a></div></div><br /><div><strong>To: </strong>akellermann, kfunk<br /><strong>Cc: </strong>volden, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>