<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2621" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Rest LGTM</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2621#inline-28795" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ghresource.cpp:173</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span><span style="color: #aa2211">&</span> <span class="n">header</span> <span style="color: #aa2211">=</span> <span class="n">metaData</span><span class="p">[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"HTTP-Headers"</span><span class="p">)];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">header</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"x-github-otp: required;"</span><span class="p">),</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">CaseSensitive</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_tfHttpHeader</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StoredTransferJob</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">job</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">outgoingMetaData</span><span class="p">()[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"customHTTPHeader"</span><span class="p">)];</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">"x-github-otp: required</tt>: Still incorrect casing. Does this work?</p>
<p style="padding: 0; margin: 8px;"><a href="https://developer.github.com/v3/auth/" class="remarkup-link" target="_blank" rel="noreferrer">https://developer.github.com/v3/auth/</a> says it's <tt style="background: #ebebeb; font-size: 13px;">X-GitHub-OTP: required;</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2621#inline-28794" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ghresource.cpp:174</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">header</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"x-github-otp: required;"</span><span class="p">),</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">CaseSensitive</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_tfHttpHeader</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StoredTransferJob</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">job</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">outgoingMetaData</span><span class="p">()[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"customHTTPHeader"</span><span class="p">)];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span style="color: #004012">twoFactorRequested</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please pass <tt style="background: #ebebeb; font-size: 13px;">m_tfHttpHeader</tt> via <tt style="background: #ebebeb; font-size: 13px;">twoFactorRequested()</tt> instead I.e. add a parameter to that function. That way you can save the extra member in this class for <tt style="background: #ebebeb; font-size: 13px;">m_tfHttpHeader</tt>.</p>
<p style="padding: 0; margin: 8px;">And in general: Please refrain from adding less known abbreviations to symbol names; it makes reading code harder.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2621#inline-28797" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ghresource.h:145</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">twoFactorRequested</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Rename: <tt style="background: #ebebeb; font-size: 13px;">twoFactorRequested</tt> -> <tt style="background: #ebebeb; font-size: 13px;">twoFactorAuthRequested</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2621" rel="noreferrer">https://phabricator.kde.org/D2621</a></div></div><br /><div><strong>To: </strong>zhigalin, mwolff, kfunk, ial0<br /><strong>Cc: </strong>mwolff, kfunk, kdevelop-devel<br /></div>