<table><tr><td style="">kossebau created this revision.<br />Restricted Application added a subscriber: kdevelop-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7084" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><a href="https://phabricator.kde.org/R33:816bf9de8b91314965de27fb5e855eb0d7486871" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">816bf9de8b91314965de27fb5e855eb0d7486871</a> added an isAbstract property<br />
to ClassMemberDeclaration, while its subclass ClassFunctionDeclaration<br />
already has had such a property, with same getter, but different setter.</p>
<p>As a result e.g. clang builder sets the property stored with<br />
ClassMemberDeclaration, while other code seeing the subclass<br />
then fetches the not set property stored with ClassFunctionDeclaration.</p>
<p>This patch fixes it in an ABI-stable way for now, by forwarding the<br />
setter/getter of ClassFunctionDeclaration to its base class.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Code paths using isAbstract() still work or rather work properly now,<br />
like the overrides page in the file template generator now properly<br />
listing abstract methods as abstract.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>BRANCH</strong><div><div>removeShadowingDuplicatedAbstractProperty</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7084" rel="noreferrer">https://phabricator.kde.org/D7084</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>language/duchain/classfunctiondeclaration.cpp<br />
language/duchain/classfunctiondeclaration.h</div></div></div><br /><div><strong>To: </strong>kossebau, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>