<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126856/">https://git.reviewboard.kde.org/r/126856/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 2nd, 2017, 10:39 a.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sadly this patch was forgotten. And only now rewritten as part of https://phabricator.kde.org/D7061 (and almost the same as in last version here :) ).
So Igor, could you please close this request as discarded, to help cleaning up remaining requests here on reviewboard? Reviewboard going to be closed soon finally in favour of phabricator, myself I have not even ever looked for kdevelop patches here.
Any remaining discussion on the things changed in this patch should be done as part of that never request now.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(And lesson to learn: in the future, best be less shy and poke maintainers again and again, especially if there already is positive feedback. as usual people only really care about their own stuff and forget about the rest, as real life also brings lots of new stuff to attention all the time, so no bad intentions :) )</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No problem. I assumed that KDevelop mainteiners are bored with the UI changes and so didn't bring this review up.
KDevelop reviews are much more active now than a year ago, which is very good.</p></pre>
<br />
<p>- Igor</p>
<br />
<p>On April 24th, 2016, 2:53 p.m. UTC, Igor Kushnir wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Igor Kushnir.</div>
<p style="color: grey;"><i>Updated April 24, 2016, 2:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove text from documentation find widget's buttons</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Screenshots: https://drive.google.com/uc?export=download&id=0B0F-aqLyFk_PRWZnS3dLQ3ZHcTQ
Note that with these changes the top Documentation Tool Bar requires more horizontal space than the documentation find widget. I proposed a solution { split the top toolbar in two rows } in https://git.reviewboard.kde.org/r/126685/ (see links to screenshots in my recent comments).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built, installed, tested both with and without documentation zoom implementation.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>documentation/documentationfindwidget.cpp <span style="color: grey">(6bf24ab6ecf52d733d13bfae9a459230dab5ca40)</span></li>
<li>documentation/documentationfindwidget.ui <span style="color: grey">(ce07311f2c89be70c45bf796a76177c0614cabd4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126856/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>