<table><tr><td style="">zhigalin requested changes to this revision.<br />zhigalin added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6690" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6690#inline-27884" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">expressionvisitor.cpp:239</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">it</span><span style="color: #aa2211">-></span><span class="n">element</span><span style="color: #aa2211">-></span><span class="n">defaultValue</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">visitStaticScalar</span><span class="p">(</span><span class="n">it</span><span style="color: #aa2211">-></span><span class="n">element</span><span style="color: #aa2211">-></span><span class="n">defaultValue</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">/kdesrc/kdev-php/duchain/expressionvisitor.cpp: In member function ‘virtual void Php::ExpressionVisitor::visitClosure(Php::ClosureAst*)’:
/kdesrc/kdev-php/duchain/expressionvisitor.cpp:246:60: error: no matching function for call to ‘Php::ExpressionVisitor::visitStaticScalar(Php::ExprAst*&)’
                 visitStaticScalar(it->element->defaultValue);
                                                            ^
In file included from /kdesrc/kdev-php/duchain/expressionvisitor.cpp:20:0:
/kdesrc/kdev-php/duchain/expressionvisitor.h:65:10: note: candidate: virtual void Php::ExpressionVisitor::visitStaticScalar(Php::StaticScalarAst*)
     void visitStaticScalar(StaticScalarAst *node) override;
          ^
/kdesrc/kdev-php/duchain/expressionvisitor.h:65:10: note:   no known conversion for argument 1 from ‘Php::ExprAst*’ to ‘Php::StaticScalarAst*’</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R52 KDevelop: PHP Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6690" rel="noreferrer">https://phabricator.kde.org/D6690</a></div></div><br /><div><strong>To: </strong>mtijink, KDevelop, zhigalin<br /><strong>Cc: </strong>zhigalin, kdevelop-devel, KDevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>