<table><tr><td style="">kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6404" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Micro-optimization at best, but looks okay.</p>

<p>Also: I usually transform <tt style="background: #ebebeb; font-size: 13px;">Foo* foo = static_cast<Foo*>(...)</tt> into <tt style="background: #ebebeb; font-size: 13px;">auto foo = static_cast<Foo*>(...)</tt> -- easier to read; there's already the type information on the RHS.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6404#inline-26887" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevdocumentview.cpp:257</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">KDevFileItem<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211">*</span> <span class="n">fileItem</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">dynam</span>ic_cast</span><span style="color: #aa2211"><</span><span class="n">KDevDocumentItem</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">item</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">fileItem</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">KDevFileItem</span><span style="color: #aa2211">*</span> <span class="n">fileItem</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">stat</span>ic_cast</span><span style="color: #aa2211"><</span><span class="n">KDevDocumentItem</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">item</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">fileItem</span><span class="p">())<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_selectionModel</span><span style="color: #aa2211">-></span><span class="n">isSelected</span><span class="p">(</span><span class="n">m_proxy</span><span style="color: #aa2211">-></span><span class="n">mapFromSource</span><span class="p">(</span><span class="n">m_documentModel</span><span style="color: #aa2211">-></span><span class="n">indexFromItem</span><span class="p">(</span><span class="n">fileItem</span><span class="p">))))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Looks like we should rather <tt style="background: #ebebeb; font-size: 13px;">Q_ASSERT(fileItem)</tt> here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6404#inline-26888" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">grepoutputmodel.cpp:263</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">current_item</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">dynam</span>ic_cast</span><span style="color: #aa2211"><</span><span class="n">GrepOutputItem</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">itemFromIndex</span><span class="p">(</span><span class="n">currentIdx</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">current_item</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">stat</span>ic_cast</span><span style="color: #aa2211"><</span><span class="n">GrepOutputItem</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">itemFromIndex</span><span class="p">(</span><span class="n">currentIdx</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Note (unrelated): Should rename <tt style="background: #ebebeb; font-size: 13px;">current_item</tt> to <tt style="background: #ebebeb; font-size: 13px;">currentItem</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6404" rel="noreferrer">https://phabricator.kde.org/D6404</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop<br /><strong>Cc: </strong>kfunk, kdevelop-devel<br /></div>