<table><tr><td style="">flherne accepted this revision.<br />flherne added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5915" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>This makes sense, I only have trivial things to mention. Compiling to test it now. Thanks!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5915#inline-24192" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">expressionvisitor.cpp:736</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">AstDefault</span>Visitor<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">visit<span class="bright">BooleanOperation</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">node</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">encounter</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">AbstractType</span><span style="color: #aa2211">::</span><span class="n">Ptr<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">new</span></span><span class="bright"> </span><span class="n"><span class="bright">IntegralType</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">IntegralType</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">TypeBoolean</span></span><span class="bright"></span><span class="p"><span class="bright">)))</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">Expression</span>Visitor<span class="bright"></span></span><span class="bright"> </span><span class="n">visit<span class="bright">or</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">this</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">AbstractType</span><span style="color: #aa2211">::</span><span class="n">Ptr<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">result</span></span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Nitpick - convention for these is either just <tt style="background: #ebebeb; font-size: 13px;">v</tt> or <tt style="background: #ebebeb; font-size: 13px;">operandVisitor</tt> (the latter usually when then there's more than one). I don't have a strong opinion.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5915#inline-24191" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pyduchaintest.cpp:510</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">newRow</span><span class="p">(</span><span style="color: #766510">"check_unsure_type_4"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"checkme = True or False"</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"bool"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">newRow</span><span class="p">(</span><span style="color: #766510">"check_unsure_type_5"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"a = </span><span style="color: #bb6622">\"</span><span style="color: #766510">foo</span><span style="color: #bb6622">\"</span><span style="color: #766510">; checkme = a or </span><span style="color: #bb6622">\"</span><span style="color: #766510">bar</span><span style="color: #bb6622">\"</span><span style="color: #766510">;"</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"str"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">newRow</span><span class="p">(</span><span style="color: #766510">"check_unsure_type_6"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"class A(): pass</span><span style="color: #bb6622">\n</span><span style="color: #766510">class B(): pass;</span><span style="color: #bb6622">\n</span><span style="color: #766510">checkme = A() or B() or 42;"</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"unsure (A, B, int)"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Nitpick - you can use single quotes for the Python strings, instead of backslashed double-quotes. They're semantically identical.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R53 KDevelop: Python Support</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5915" rel="noreferrer">https://phabricator.kde.org/D5915</a></div></div><br /><div><strong>To: </strong>nalvarez, brauch, flherne<br /><strong>Cc: </strong>flherne, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>