<table><tr><td style="">aaronpuchert added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5621" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5621#inline-22939" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kossebau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kdevclang.xml:12</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/aaronpuchert/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@aaronpuchert</a>, given <a href="https://phabricator.kde.org/D5485" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" rel="noreferrer">D5485</a> this indeed should be "OpenCL C source code", not "OpenCL source code", right?</p>

<p style="padding: 0; margin: 8px;">If so, someone with knowledge should write a patch to fix-up the entry in shared-mime-info, which is without the "C": <a href="https://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=4ab969c398671c519a10a601ad3eeb46f04361de" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=4ab969c398671c519a10a601ad3eeb46f04361de</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yes, that is the <a href="https://www.khronos.org/registry/OpenCL/specs/opencl-2.0-openclc.pdf" class="remarkup-link" target="_blank" rel="noreferrer">official name</a> of the language. I'd also argue that the mime type should be <tt style="background: #ebebeb; font-size: 13px;">text/x-opencl-csrc</tt>.</p>

<p style="padding: 0; margin: 8px;">The reason being that there is also <a href="https://www.khronos.org/registry/OpenCL/specs/opencl-2.2-cplusplus.pdf" class="remarkup-link" target="_blank" rel="noreferrer">OpenCL C++</a> (since <a href="https://en.wikipedia.org/wiki/OpenCL#OpenCL_2.1" class="remarkup-link" target="_blank" rel="noreferrer">OpenCL 2.1</a>), though that is not yet supported by Clang.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5621" rel="noreferrer">https://phabricator.kde.org/D5621</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop, qi437103, aaronpuchert<br /><strong>Cc: </strong>kdevelop-devel<br /></div>