<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5042" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5042#95988" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D5042#95988</a>, <a href="https://phabricator.kde.org/p/apol/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@apol</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Then please, let me submit this change and as soon as there's something we can share with Kontact I'll do the port myself.</p></div>
</blockquote>
<p>Please let's keep the possibility to build against QtWebKit, but prefer QtWebEngine whenever it is detected. That just needs some <tt style="background: #ebebeb; font-size: 13px;">#ifdefs</tt> & CMake defines.</p>
<p>Note we already had a similar patch before, allowing to select between QTextBrowser & QtWebEngine. Unfortunately we cannot use QTextBrowser, though, because of reasons already mentioned before.</p>
<p>So, generally: +1, but please don't just commit this patch and let people wait for the QtWebKit version to return. Support both QtWebKit/QtWebEngine before pushing this.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5042#inline-20887" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qthelpdocumentation.cpp:140</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QUrl</span> <span class="n">url</span><span class="p">(</span><span class="n">m_current</span><span class="p">.</span><span class="n">value</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qDebug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"xxxxxxxxxxx"</span> <span style="color: #aa2211"><<</span> <span class="n">url</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QByteArray</span> <span class="n">data</span> <span style="color: #aa2211">=</span> <span class="n">m_provider</span><span style="color: #aa2211">-></span><span class="n">engine</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">fileData</span><span class="p">(</span><span class="n">url</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please remove</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5042#inline-20888" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qthelpdocumentation.cpp:263</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">file</span><span style="color: #aa2211">-></span><span class="n">close</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">view</span><span style="color: #aa2211">-></span><span class="n">settings</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setUserStyleSheetUrl</span><span class="p">(</span><span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span class="n">file</span><span style="color: #aa2211">-></span><span class="n">fileName</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #74777d"><span class="bright">// </span> view->settings()->setUserStyleSheetUrl(QUrl::fromLocalFile(file->fileName()));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Dito</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5042" rel="noreferrer">https://phabricator.kde.org/D5042</a></div></div><br /><div><strong>To: </strong>apol, KDevelop, kfunk<br /><strong>Cc: </strong>kfunk, ltoscano, mwolff, kossebau, brauch, nalvarez, tcberner, kdevelop-devel<br /></div>