<table><tr><td style="">mwolff requested changes to this revision.<br />mwolff added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4772" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>sorry for the delay Alexander</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20906" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cutcopypastehelpers.cpp:78</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QTreeWidgetItem</span> <span style="color: #aa2211">*></span> <span class="n">items</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">TaskInfo</span><span style="color: #aa2211">&</span> <span class="n">task</span><span class="p">,</span> <span class="n">tasks</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">srcCount</span> <span style="color: #aa2211">=</span> <span class="n">task</span><span class="p">.</span><span class="n">m_src</span><span class="p">.</span><span class="n">size</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">add a TODO to create a model for the task list, and use it here instead of using QTreeWidget</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20908" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cutcopypastehelpers.cpp:78</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QTreeWidgetItem</span> <span style="color: #aa2211">*></span> <span class="n">items</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">TaskInfo</span><span style="color: #aa2211">&</span> <span class="n">task</span><span class="p">,</span> <span class="n">tasks</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">srcCount</span> <span style="color: #aa2211">=</span> <span class="n">task</span><span class="p">.</span><span class="n">m_src</span><span class="p">.</span><span class="n">size</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">also here and elsewhere: do not use foreach, use range-based for</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20907" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cutcopypastehelpers.cpp:186</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">void</span> <span class="n">classifyPaths</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">Path</span><span style="color: #aa2211">::</span><span class="n">List</span><span style="color: #aa2211">&</span> <span class="n">paths</span><span class="p">,</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectModel</span><span style="color: #aa2211">*</span> <span class="n">projectModel</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">IProject</span><span style="color: #aa2211">*</span><span class="p">,</span> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span><span style="color: #aa2211">*>>&</span> <span class="n">itemsPerProject</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">again return a struct, instead of using out parameters</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20909" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cutcopypastehelpers.cpp:226</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Path</span><span style="color: #aa2211">::</span><span class="n">List</span> <span class="n">pathsList</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span> <span class="p">(</span><span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span><span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">,</span> <span class="n">itemsList</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">pathsList</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">item</span><span style="color: #aa2211">-></span><span class="n">path</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">add braces</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20910" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cutcopypastehelpers.cpp:337</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">QDialog</span><span style="color: #aa2211">></span> <span class="n">guardedDialog</span> <span style="color: #aa2211">=</span> <span class="n">dialog</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">guardedDialog</span><span style="color: #aa2211">-></span><span class="n">exec</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">dialog->setAttribute(Qt::WA_DeleteOnClose);
dialog->show();</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20903" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cutcopypastehelpers.h:59</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span style="color: #004012">getSrcDestMapping</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">Path</span><span style="color: #aa2211">::</span><span class="n">List</span><span style="color: #aa2211">&</span> <span class="n">paths</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">Path</span><span style="color: #aa2211">&</span> <span class="n">destPath</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">Path</span><span style="color: #aa2211">::</span><span class="n">List</span><span style="color: #aa2211">&</span> <span class="n">filteredPaths</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">rename to <tt style="background: #ebebeb; font-size: 13px;">mapSourceToDestination</tt>, return a struct with the mapping instead of taking two out-parameters</p>
<p style="padding: 0; margin: 8px;">rename first <tt style="background: #ebebeb; font-size: 13px;">paths</tt> argument to sourcePaths, rename <tt style="background: #ebebeb; font-size: 13px;">destPath</tt> to <tt style="background: #ebebeb; font-size: 13px;">destinationPath</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20904" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cutcopypastehelpers.h:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">TaskInfo</span><span style="color: #aa2211">></span> <span class="n">copyMoveItems</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">Path</span><span style="color: #aa2211">::</span><span class="n">List</span><span style="color: #aa2211">&</span> <span class="n">paths</span><span class="p">,</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">ProjectBaseItem</span><span style="color: #aa2211">*</span> <span class="n">destItem</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span style="color: #aa4000">bool</span> <span class="n">isCut</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please use an enum instead of a boolean here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20905" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cutcopypastehelpers.h:65</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span style="color: #004012">warningPasteFailed</span><span class="p">(</span><span class="n">QWidget</span><span style="color: #aa2211">*</span> <span class="n">parent</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">TaskInfo</span><span style="color: #aa2211">>&</span> <span class="n">tasks</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">rename to <tt style="background: #ebebeb; font-size: 13px;">showWarningDialogForFailedPaste</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4772#inline-20911" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">projectmanagerviewplugin.cpp:728</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">task</span><span class="p">.</span><span class="n">m_status</span> <span style="color: #aa2211">==</span> <span class="n">CutCopyPasteHelpers</span><span style="color: #aa2211">::</span><span class="n">TaskStatus</span><span style="color: #aa2211">::</span><span class="n">SUCCESS</span> <span style="color: #aa2211">&&</span> <span class="n">task</span><span class="p">.</span><span class="n">m_type</span> <span style="color: #aa2211">!=</span> <span class="n">CutCopyPasteHelpers</span><span style="color: #aa2211">::</span><span class="n">TaskType</span><span style="color: #aa2211">::</span><span class="n">DELETION</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">Path</span><span style="color: #aa2211">&</span> <span class="n">src</span><span class="p">,</span> <span class="n">task</span><span class="p">.</span><span class="n">m_src</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">finalPathsList</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">finalPaths</span><span class="p">[</span><span class="n">src</span><span class="p">]);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">add braces</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4772" rel="noreferrer">https://phabricator.kde.org/D4772</a></div></div><br /><div><strong>To: </strong>aspotashev, kfunk, mwolff<br /><strong>Cc: </strong>kdevelop-devel<br /></div>