<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4981" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>-1 as it is. The changes to <tt style="background: #ebebeb; font-size: 13px;">IBasicVersionControl</tt> are fine IMO, but the ones to the other interfaces need careful reconsideration.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4981#inline-20399" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">perforceplugin.h:91</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">VcsRevision</span><span style="color: #aa2211">&</span> <span class="n">dstRevision</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">contextLines</span><span style="color: #aa2211">=-</span><span style="color: #601200">1</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">VcsDiff</span><span style="color: #aa2211">::</span><span class="n">Type</span> <span style="color: #aa2211">=</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">VcsDiff</span><span style="color: #aa2211">::</span><span class="n">DiffUnified</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ditch the <tt style="background: #ebebeb; font-size: 13px;">const</tt>. Not needed for POD types.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4981#inline-20398" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevsvnplugin.cpp:240</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">contextLines</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_contextLines</span> <span style="color: #aa2211">=</span> <span class="n">contextLines</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why does this store <tt style="background: #ebebeb; font-size: 13px;">contextLines</tt> into a member? That's totally cumbersome from a API POV.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4981#inline-20400" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevsvnplugin.h:158</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">ThreadWeaver</span><span style="color: #aa2211">::</span><span class="n">Queue</span><span style="color: #aa2211">*</span> <span class="n">m_jobQueue</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">m_contextLines</span><span style="color: #aa2211">=</span><span style="color: #601200">3</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Makes no sense to have this as member</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4981#inline-20401" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ibasicversioncontrol.h:197</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">VcsRevision</span><span style="color: #aa2211">&</span> <span class="n">dstRevision</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">contextLines</span><span style="color: #aa2211">=-</span><span style="color: #601200">1</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">VcsDiff</span><span style="color: #aa2211">::</span><span class="n">Type</span> <span style="color: #aa2211">=</span> <span class="n">VcsDiff</span><span style="color: #aa2211">::</span><span class="n">DiffUnified</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Dito, ditch <tt style="background: #ebebeb; font-size: 13px;">const</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4981#inline-20402" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ipatchsource.h:53</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">///The default implementation ignores the argument and calls update()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">virtual</span> <span style="color: #aa4000">void</span> <span style="color: #004012">update</span><span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">update</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I really don't like this API, but can't think of anything better right now.</p>
<p style="padding: 0; margin: 8px;">If at all, this needs better API documentation, with named arguments in the signature + <tt style="background: #ebebeb; font-size: 13px;">@param</tt> in doxygen, etc.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4981#inline-20403" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">vcsdiffpatchsources.h:45</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">virtual</span> <span style="color: #aa2211">~</span><span class="n">VCSDiffUpdater</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">virtual</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">VcsDiff</span> <span class="n">update</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">virtual</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">VcsDiff</span> <span class="n">update</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> </span><span class="n"><span class="bright">lines</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">=-</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="p">)</span> <span style="color: #aa4000">const</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">virtual</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">IBasicVersionControl</span><span style="color: #aa2211">*</span> <span class="n">vcs</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Still, odd API. <tt style="background: #ebebeb; font-size: 13px;">lines</tt> is ambiguous, too, should be <tt style="background: #ebebeb; font-size: 13px;">contextLines</tt> if at all.</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4981" rel="noreferrer">https://phabricator.kde.org/D4981</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop, kfunk<br /><strong>Cc: </strong>kfunk, apol, kdevelop-devel, KDevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>